Problem/Motivation

#1020842: Error messages when importing translated strings fails are not helpful at all showed that there is no nice way to link to the log report from an on-screen error message. I can't think of a good way to do this either, but opening this for discussion.

Steps to reproduce

?

Proposed resolution

?

Remaining tasks

Test coverage.

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#6 1325736-6-consistent-dblog-link.patch1.9 KBdagmar

Comments

yoroy’s picture

yoroy commented
Issue tags: +Usability

Nice small example of needing to find ways to 'connect the dots'.

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes

Especially because error messages are potentially stored in an inaccessible format within Drupal, this sounds kind of impossible.

dawehner’s picture

dawehner
Primary language German
commented
Component: base system » dblog.module

Let's move it to dblog, the only place which can actually handle that.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Issue tags: +Needs issue summary update

So this came from https://www.drupal.org/node/1020842#comment-5177294 but is not clear to me what is the type of desired solution. I know this says I can't think of a good way to do this either, but opening this for discussion. but no discussion has been made here.

Maybe some screenshots to understand better what is the issue here?

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Version: 8.1.x-dev » 8.2.x-dev
Status: Active » Needs review
StatusFileSize
new 1325736-6-consistent-dblog-link.patch1.9 KB

What about this solution?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
Issue tags: +Needs tests 
+++ b/core/modules/dblog/src/Logger/DbLog.php
@@ -109,4 +110,47 @@ public function log($level, $message, array $context = array()) {
+   * @return string|boolean

This does not return a string, it returns a Url object, right?

And we should have some sort of test case for this to ensure the method works correctly.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented

Thanks for your feedback. I'm working on the tests. In the meantime I have a few questions.

  1. Is the Logger class the right class to introduce this method?
  2. The URL is converted toString so this function returns string not and URL object, right?
  3. If previous statment is correct, should we return an URL object instead?
  4. Should I add the severity for as a parameter?
  5. Makes sense to include a fix for #1020842: Error messages when importing translated strings fails are not helpful at all here or can we use a follow up?

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
commented

I really love the functionality this offers! There should be some kind of interface maybe, to allow other logger implementations to do something similar.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented

We are working on that interface here #2458191: Provide a storage backend for dblog module :)

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs work » Postponed

Postponing this until we have a DblogStorage::loadMultiple method in place (#2458191: Provide a storage backend for dblog module). Then we can use it to load the first messages that match with the given specifications.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed » Active

Believe blocker has since landed.

oily’s picture

oily commented
Issue summary: View changes
oily’s picture

oily commented
Issue summary: View changes

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.