user_save is called in ldapauth_authenticate as well as ldapgroups_user_login(), whether or not the data being passed is different. This results in many unnecessary hooks being fired.

Attached patch checks the ldap data/roles before saving. I also included a patch against the older dev version of this module since I'm still on that.

CommentFileSizeAuthor
ldap_integration_dont_blindly_user_save-older.patch1.26 KBmsonnabaum
ldap_integration_dont_blindly_user_save.patch1.25 KBmsonnabaum

Comments

john franklin’s picture

john franklin commented
Issue summary: View changes
Status: Active » Needs review

With a patch attached, the status should be "needs review."