Originally reported by webchick via #drupal
Tested by dmitrig01 and simplymenotu

-------------------
Testing results
-------------------

add category, then add feed

* notice: Undefined index: fid in /modules/aggregator/aggregator.module on line 531.
* notice: Undefined index: fid in /modules/aggregator/aggregator.module on line 535.
* notice: Undefined index: fid in /modules/aggregator/aggregator.module on line 538.

viewing feed BEFORE updating items

* warning: array_keys() [function.array-keys]: The first argument should be an array in /modules/user/user.module on line 365.
* warning: implode() [function.implode]: Bad arguments. in /modules/user/user.module on line 365.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT DISTINCT(p.perm) FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN () in /includes/database.mysql.inc on line 172.

updating items manually for a feed

* notice: Undefined index: REL in /modules/aggregator/aggregator.module on line 601.
* notice: Undefined offset: 1 in /modules/aggregator/aggregator.module on line 652.
* notice: Undefined index: ITEM in /modules/aggregator/aggregator.module on line 652.
* notice: Undefined index: TITLE in /modules/aggregator/aggregator.module on line 652.
* notice: Undefined index: REL in /modules/aggregator/aggregator.module on line 601.
* notice: Undefined index: LINK in /modules/aggregator/aggregator.module on line 652.
* notice: Undefined index: DESCRIPTION in /modules/aggregator/aggregator.module on line 652.
* notice: Undefined index: PUBDATE in /modules/aggregator/aggregator.module on line 652.
* notice: Undefined index: DC:CREATOR in /modules/aggregator/aggregator.module on line 652.
* notice: Undefined index: GUID in /modules/aggregator/aggregator.module on line 652.
* notice: Undefined index: CONTENT:ENCODED in /modules/aggregator/aggregator.module on line 875.
* notice: Undefined index: SUMMARY in /modules/aggregator/aggregator.module on line 878.
* notice: Undefined index: CONTENT in /modules/aggregator/aggregator.module on line 881.
* notice: Undefined index: AUTHOR in /modules/aggregator/aggregator.module on line 926.
* notice: Undefined index: LINK in /modules/aggregator/aggregator.module on line 739.
* notice: Undefined index: ETag in /modules/aggregator/aggregator.module on line 751.

viewing feed AFTER updating items manually

NOTE: there has to be entries in the feed, a null feed will not return errors

# notice: Undefined property: ftitle in /modules/aggregator/aggregator.module on line 1364.
# notice: Undefined variable: output in /modules/aggregator/aggregator.module on line 1375.

CommentFileSizeAuthor
#1 aggregator_notice.patch4.43 KBcsevb10
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

csevb10’s picture

Status: Active » Needs review
FileSize
4.43 KB

This patch should fix everything except the user.module errors (which I tracked back to a user_access hook error...it's easy to fix there, but I've still got to determine why the wrong values are being passed in).
I used !empty calls for all the array calls and isset for the 2 object calls.
The modifications are easy, so let's just get these fixes and pushed in.

RobRoy’s picture

Priority: Critical » Normal
Status: Needs review » Needs work

I used !empty calls for all the array calls and isset for the 2 object calls.

empty vs. isset has nothing to do with array vs. object. Please see http://us.php.net/manual/en/types.comparisons.php.

Marking code needs work as this probably needs another check. Also, this is not critical.

csevb10’s picture

hehe. Thanks. I already knew the 2 had nothing to do with object vs array.
It was simply a choice on my part, so I thought I would mention it.
Other than changing the status, you didn't really help advance this issue, though, do you have any comments about where I chose to use the isset vs empty?
I think the empty checks around the queries is definitely the right way to go, for some of the static text checks, isset might be the better option, but I was hoping to get someone else's input.

csevb10’s picture

Status: Needs work » Needs review

Also, this code still needs to be reviewed. It works either way, despite my choice of empty vs isset, so I'm gonna push this back to code needs review so it'll get reviewed and critiqued.

dvessel’s picture

There are a bunch of other errors that this other patch fixes. http://drupal.org/node/150782

In combination with this, it seems to work fine. Tons of hunk offset errors. Didn't fully test though.

Dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)