Currently fbconnect checks for fb_avatar value, but it is never set.

IMO, a follow up patch should deprecate the $user->data['fb_avatar'] and move this value to {fb_connect} in the DB. It's bad practice to save stuff to $user->data...

CommentFileSizeAuthor
#3 fbconnect-reg_settings-1321964-3.patch702 bytessoomp
fbconenct-picture-register-1.patch1.27 KBamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Needs review

Correct status.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

This is now in my sanbox -- https://github.com/amitaibu/fbconnect , which overhauls some of the messy parts of fbconnect.

soomp’s picture

soomp commented
Title: Save fb_avatar setting on user register. » Save fb_avatar & friend settings on user register.
StatusFileSize
new fbconnect-reg_settings-1321964-3.patch702 bytes

Sorry, your patch didn't work for me.

I created a simpler version which corrects the $data array it sends to user_save() (from $data['fb_avatar'] to $data['data']['fb_avatar']). It also correctly saves the option to be visible to your friends as well.

Hope this helps someone.

jcisio’s picture

jcisio commented
Title: Save fb_avatar & friend settings on user register. » Save fb_avatar & friend settings on user register
Status: Needs review » Fixed

Committed #3 as it simpler and does not introduce new feature. Thanks to both.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.