Sort "Edit components" SELECT alphabetically [#1313744]

Comment	File	Size	Author
#8	features-1313744-8.patch	1.16 KB	traviscarden
#3	features-1313744-3.patch	868 bytes	traviscarden
#1	features-1313744-1.patch	858 bytes	traviscarden
	features-components-select.jpg	77.27 KB	traviscarden

Comment #1

traviscarden commented 18 October 2011 at 20:36

Assigned:	traviscarden	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	features-1313744-1.patch	858 bytes

Log in or register to post comments

Comment #2

hefox commented 22 October 2011 at 23:11

Version:	6.x-1.x-dev	» 7.x-1.x-dev
Status:	Needs review	» Needs work

applies cleaning to 7.x but

Parse error: syntax error, unexpected T_FUNCTION in [..]/features.admin.inc on line 70

Log in or register to post comments

Comment #3

traviscarden commented 23 October 2011 at 07:19

Status	File	Size
new	features-1313744-3.patch	868 bytes

Aw, nuts! PHP doesn't support anonymous functions before version 5.3. Well, here's a new patch accounting for that, rolled against 7.x-1.x-dev.

Log in or register to post comments

Comment #4

traviscarden commented 3 November 2011 at 13:20

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #5

febbraro commented 3 November 2011 at 15:59

Status:

Needs review

» Needs work

+++ b/features.admin.incundefined
@@ -67,7 +67,10 @@ function features_export_form($form, $form_state, $feature = NULL) {
+  function compare($a, $b) {

All functions in PHP have global scope so this needs to be better namespaced and should also be moved external to the features_export_form function.