We've seen SOAP errors (below) in the logs resulting from empty URI arrays when custom modules remove all paths via hook_akamai_paths_alter(). It seems to me that the function should terminate if the paths array comes back empty after the calls to _akamai_get_all_paths().

The attached patch adds in a quick check for an empty paths array and logs the occurrence via watchdog() and returns FALSE if that occurs.

Error Clearing Akamai Cache: Exception: class com.idoox.soap.DemarshallException: Type in schema differs from type in SOAP message - expected string@http://www.w3.org/1999/XMLSchema; got ur-type@http://www.w3.org/2001/XMLSchema

CommentFileSizeAuthor
#4 terminate_clear_if_no_paths-1312508-4.patch473 bytescuebix
terminate_clear_if_no_paths.patch893 bytesbarrett

Comments

febbraro’s picture

febbraro commented

Fixed in D7, still needs a fix in D6

barrett’s picture

barrett commented

Since it still needs a fix in D6, how about applying the patch I posted and rolling a new D6?

barrett’s picture

barrett commented

Any chance of getting this applied for d6 so we can get an error off our logs?

cuebix’s picture

cuebix commented
Version: 6.x-1.2 » 7.x-1.3
StatusFileSize
new terminate_clear_if_no_paths-1312508-4.patch473 bytes

I'm running the latest version of the D7 code and I don't see the patch applied.

I also don't agree with it returning a return value of false; if no paths are supplied, the function did exactly what it was supposed to - nothing - so it should return true.

I've attached a revised patch for D7 for review.

barrett’s picture

barrett commented
Issue summary: View changes
Status: Needs review » Fixed

This is fixed in the HEAD of the 7.x-1.x branc, but a new version of the module has not been released. Since there's not a dev release, you'll have to use a checkout from git.

$ git log --pretty=oneline --decorate=full
4bdc96027b163a464500196ea07e4ec5a7dff14a (HEAD, refs/remotes/origin/7.x-1.x, refs/heads/queue-6, refs/heads/7.x-1.x) Issue #1312508 by Barrett: Fixed halt processing of akamai_clear
16264514e39224e9aacf7e36a9453766d127e623 (tag: refs/tags/7.x-1.3) Fixed problem with path label

  • Commit 4bdc960 on 7.x-1.x, 8.x-1.x by febbraro: 
    Issue #1312508 by Barrett: Fixed halt processing of akamai_clear_url()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 4bdc960 on 7.x-1.x, 8.x-1.x, 7.x-2.x by febbraro: 
    Issue #1312508 by Barrett: Fixed halt processing of akamai_clear_url()...

  • Commit 4bdc960 on 7.x-1.x, 8.x-1.x, 7.x-2.x, 8.x-2.x by febbraro: 
    Issue #1312508 by Barrett: Fixed halt processing of akamai_clear_url()...