[D7] Login Activity

Hi vaidik,

I reviewed your code and saw some issues:

• .info description is required. See http://drupal.org/node/542202 for more info.
• In login_activity_schema(), you should not be wrapping database descriptions in t(). See http://drupal.org/node/332123 for more info. For future projects, anything in install files should use get_t() instead of t(). For this project, you don't have any reason to use either.
• file_save_data('test'); This shouldn't be here. Is this for debugging? You might want to use the Devel module for that.
• Minor issue: your indentation is more than the standard 2 spaces, which makes the code a little harder to read.
• This code doesn't seem to do as much as the description suggests. You wrote "If a user notices unusual activity [...]" but the activity isn't displayed to users anywhere, so how would they ever notice it? Have you considered displaying the user log in Drupal so users don't need to look at it directly in the database?

Please change the status back to "needs review" when these issues are fixed.

Hi vaidik,

Your changes look great. I noticed one security issue that needs to be fixed:

    $variables['rows'][] = array(
      'data' => array(
        format_date($row->timestamp, 'long'),
        $row->hostname,
        $row->host_user_agent,
      ),
    );

Both $row->hostname and $row->host_user_agent should be wrapped in check_plain(), as those values from $_SERVER could be potentially populated with harmful HTML.

Once that's fixed, please set this back to "needs review."

Looks good to me.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

For translation, don't escape the quote, use double quotes around it.
return t('You don\'t have rights to get details of other users.');
Should be:
return t("You don't have rights to get details of other users.");

Thanks for your contribution, vaidik! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.

I am giving credits to the users who participated in this issue and in the issue marked as duplicate.