Additional validation when creating terms - assert the Vocabulary is valid [#1305698]

Although the UI sorta tries to prevent you from messing it up, it is still possible to save imported terms with an incorrect (or unset) vocabulary ID.
I could end up with a number of homeless terms in the database, assigned to no vocab. This makes them invisible, and also hides any problem the import was having.
As taxonomy_term_save() doesn't check if the new term actually has a vocab ID set, we must do it ourselves.
Patch coming.

Comment	File	Size	Author
#1	feedsTermProcessor-validate_vocabulary-1305698-20111010.patch	480 bytes	dman
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dman CreditAttribution: dman commented 11 October 2011 at 04:11

Status:

Active

» Needs review

File	Size
feedsTermProcessor-validate_vocabulary-1305698-20111010.patch	480 bytes

+    if (empty($term->vid)) {
+      throw new FeedsValidationException(t('Term vocabulary missing.'));
+    }

Comment #2

twistor CreditAttribution: twistor commented 5 February 2014 at 04:42

Issue summary:	View changes
Status:	Needs review	» Fixed

I couldn't reproduce this.

I've added a test here, to verify things.
http://drupalcode.org/project/feeds.git/commit/d66f313

FeedsTermProcessor::vocabulary() throws an exception if a vocabulary doesn't exist. If I'm missing something, please mention it.

It has been a long time, so who knows.

Comment #3

dman CreditAttribution: dman commented 5 February 2014 at 22:02

To replicate you'd need a data source that supplied raw tid data that you thought you could trust, but if, for example you'd deleted the target term locally (or otherwise just had crappy input) then this would make it into the system.
Or at least it seemed that it did WAY back when I found this issue.
Probably good now - the patch was just a fix that I needed at that time (due to bad input) then so shared.

Cheers!