I am comparing RC2 with the dev version I am using. There seems to be mixed updates.
uc_cart.module:
uc_cart_get_item:
The RC2 adds the following line to make display_price work.
$item->display_price = $product->display_price;

uc_cart_get_contents RC2 has:
$item->display_price = $product->sell_price;
while the dev version has:
$item->display_price = $product->display_price;

Comments

longwave’s picture

Title: $item->display_price = $product->sell_price; » Deduplicate uc_cart_get_item() and uc_cart_get_contents()
Version: 7.x-3.0-rc2 » 7.x-3.x-dev

Good catch, fix committed. uc_cart_get_item() isn't actually used in core, so this would only have affected contrib. We could reduce code duplication here, so I'm retitling this issue to deal with that.

longwave’s picture

Status: Active » Needs review
StatusFileSize
new2.35 KB
Island Usurper’s picture

Status: Needs review » Fixed

Good fix. Committed.

longwave’s picture

Version: 7.x-3.x-dev » 6.x-2.x-dev
Status: Fixed » Patch (to be ported)

Might as well do the same in 6.x.

longwave’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new2.44 KB
longwave’s picture

StatusFileSize
new2.44 KB

Oops, use this one

Status: Needs review » Needs work

The last submitted patch, 1305634-uc_cart_get_item.patch, failed testing.

longwave’s picture

Status: Needs work » Needs review

Test failures are unrelated:

User mFxJ6ot1myk856JgxCR5 successfully logged in.
Raw "While logged in" found

Seems to be something to do with the random username/password not always working here?

longwave’s picture

#6: 1305634-uc_cart_get_item.patch queued for re-testing.

longwave’s picture

Status: Needs review » Fixed

Committed #6

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.