file_check_directory takes a reference, which means that file_check_directory(function()) results in a:

Fatal error: Only variables can be passed by reference in [path]/project_issue/issue.inc on line 658
CommentFileSizeAuthor
#1 pi_reference.patch804 bytesheine
pi_check_directory_0.patch3.23 KBheine

Comments

heine’s picture

heine commented
StatusFileSize
new pi_reference.patch804 bytes

Ehm, little patch mixup - that was the patch that introduced the problem. Here's a fix.

heine’s picture

heine commented
Title: file_check_upload takes a reference » file_check_directory takes a reference
dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

patch works fine under testing, and the code looks good, so i committed to HEAD, DRUPAL-4-7--2 an DRUPAL-4-7. however, i couldn't see this error on either php 4.4 or 5.2. where were you're seeing it? just curious. ;)

thanks!

heine’s picture

heine commented

Nah, someone in #drupal-support with PHP 5 (never replied to a request for the minor version), but I felt compelled to fix my bug :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)