When using a http://example.com/subscriptions/del/... link, below the "Are you sure you want to unsubscribe?" title, it says "This action cannot be undone", which seems wrong, since the user can certainly resubscribe. I suspect this is a standardized thing that Core does, not this module, so perhaps the issue should be moved to Core. I searched Core issues and didn't see anything that looked relevant. And I don't know how I might avoid this showing, though perhaps I can hide it in this specific context with CSS.

CommentFileSizeAuthor
#10 inapproppriate-message-1301798-10.patch871 bytesldpm

Comments

salvis’s picture

Status: Active » Closed (works as designed)

Yes, if you delete a node, you can also recreate it, but you cannot undo the deletion.

After unsubscribing, it may even be difficult to find out the type of the subscription that was just removed.

The client module can choose whether to display that sentence or not, and Subscriptions chooses to do so.

David D’s picture

Hmm. I don't see how this makes much sense, nor how "deleting a node" is relevant. If someone cancels their subscription, can't they resubscribe the same way they may have to begin with? The way it is, we're telling the user that if they cancel their subscription, they cannot resubscribe, which is just wrong, at least as far as how it works on my site. Why worry the user like this?

salvis’s picture

Deleting a node is just another action where "This action cannot be undone" is displayed.

It's typically displayed when some data is permanently removed from the database (rather than just being hidden, as when you unpublish a node).

Unsubscribing removes the subscription as well as any pending queue items for that subscription. You can redo the subscription, but you cannot undo the removal of the subscription.

David D’s picture

I understand what you are saying with,

Unsubscribing removes the subscription as well as any pending queue items for that subscription. You can redo the subscription, but you cannot undo the removal of the subscription.

I believe this is a distinction that is going to be irrelevant to the vast majority of users, making it poor UX to present such a statement to them. What matters to them is whether they can later change their mind and resubscribe, and in fact they can, contrary to what they are being told by that message.

I really, really appreciate what you have provided with this project, Hans, and I don't mean to be a jerk. It does seem, though, like you might be a little stuck in a coder's mindset, and maybe not seeing the forest for the trees.

salvis’s picture

Status: Closed (works as designed) » Active

Ok, let's keep this open and see whether we can get some additional opinions.

David D’s picture

Thank you. I'll be curious to hear from others as well.

Traverus’s picture

Why not keep the extra warning and clicks, just change the warning message to something like

You are unsubscribing from (foo) and may resubscribe at a later date. Any pending notifications will be lost.

You could additionally have a check box that sends any pending notifications if checked, and change above wording to that end.

I do agree that the extra warning should continue to exist regardless.

salvis’s picture

You are unsubscribing from (foo) and may resubscribe at a later date. Any pending notifications will be lost.

It's not quite as easy as this. If you are bulk-unsubscribing 100 users, an unknown percentage of them may have unsubscribed by themselves before (after all there must be a reason for you to unsubscribe them). The ones who are still subscribed may start complaining to you and after 5 heated complaints you may come to realize that you shouldn't have done this. However, if you resubscribe the 100 users, you'll get complaints from the ones that have unsubscribed themselves. IOW, if you do this, you can't win, and you definitely and irrevocably lose data.

Also, we cannot fill in "(foo)" because we don't know what it is.

ldpm’s picture

Assigned: Unassigned » ldpm
Issue summary: View changes

We are definitely having this issue, where at least one user has told us that they were afraid to confirm because they thought they'd never be able to resubscribe in the future. I'm working on a quick patch for anyone who wishes to use it, whether or not it is ever merged in to the module.

ldpm’s picture

Assigned: ldpm » Unassigned
Status: Active » Needs review
StatusFileSize
new871 bytes

Simple fix is to add a "description" message to the confirm_form call in subscriptions_delete_form. Based on the previous comments and my own needs, I've chosen "You can always resubscribe later. Any pending notifications may be lost."

  • 87268f1 committed on 7.x-1.x
    #1301798 by ldpm: Fix inappropriate 'This action cannot be undone'...
salvis’s picture

Status: Needs review » Fixed

That works for me -- thanks, ldpm!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.