If #tree option is TRUE server site validation is broken in richform_regex module, because richform_regex_richform_validate function use wrong element id.

We should use $element['#value'] instead of $form_state['values'][$id].

There is same problem with the correction function.

CommentFileSizeAuthor
#4 richform_regex-tree_true_bug-1298866-4-6.x.patch4.04 KBDésiré
#4 richform_regex-tree_true_bug-1298866-4-7.x.patch4.1 KBDésiré
#1 richform_regex-tree_true_bug-example_only-7.x-1.x.patch697 bytesDésiré
#1 richform_regex-tree_true_bug-7.x-1.x.patch1.65 KBDésiré

Comments

Désiré’s picture

Désiré commented
StatusFileSize
new richform_regex-tree_true_bug-7.x-1.x.patch1.65 KB
new richform_regex-tree_true_bug-example_only-7.x-1.x.patch697 bytes

There is two patches:
- one just for the example module for bug reproduction
- and one for both the example module and the fixed richform_regex module

Désiré’s picture

Désiré commented

The patches above works for the 6.x-1.x version too.

pp’s picture

pp commented
Status: Active » Needs work

It's looking good, but one thing: Please correct all funtions footprint to same.

Désiré’s picture

Désiré commented
Status: Needs work » Needs review
StatusFileSize
new richform_regex-tree_true_bug-1298866-4-7.x.patch4.1 KB
new richform_regex-tree_true_bug-1298866-4-6.x.patch4.04 KB
pp’s picture

pp commented

Désiré: Can you reroll the patch and add some tests to it?

pp’s picture

pp commented
Status: Needs review » Needs work