First, let me premise this with the fact that I know Form Builder is not designed to be injected into an existing form, but I have managed to do so and it works fantastically... mostly.
So far the only problem I have come across is when rendering it inside a Fieldset, especially a collapsible fieldset.
- The settings tabs inherit styles from the fieldset, which isn't surprising given their class is 'fieldset-legend'.
- The form palette jumps all over the place and doesn't show up where it's supposed to be.
I suspect this will be a very low priority issue given that I'm doing things with the module that it wasn't designed to do, so the point of this issue is more to record the issue and have a place for me to potentially submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | form_builder-pre-patch.png | 19.51 KB | realityloop |
| #3 | form_builder-post-patch.png | 21.53 KB | realityloop |
| #1 | form_builder_fieldset_issues-1297784-1.patch | 585 bytes | deciphered |
Comments
Comment #1
decipheredPatch attached resolves the issue of the Tabs display, removes the unused/unnecessary 'fieldset-legend' which is left over from the conversion from fieldset to tabs.
Marking as 'needs review' as this patch fixes one major part of the issue without any negative side effects, and the other issue is temporarily fixable by starting the collapsible fieldset open.
Comment #2
decipheredFor anyone wanting to review/test this patch, you'll need the 'form_builder' branch of Custom Formatters, available from https://github.com/Decipher/custom_formatters/tree/form_builder.
Simply have the 'form_builder' branch of Custom Formatters and Form Builder 7.x-1.x-dev enabled, and create/edit a PHP Custom Formatter to see the Form Builder functionality and to reproduce the issue/test the fix.
Comment #3
realityloop commentedCan confirm the issue and that the patch resolves it, see attached images
Comment #4
decipheredTitle fix just because...
Comment #5
quicksketchThanks guys, finally committed.