On every page I'm getting this error:
Strict warning: Declaration of SearchApiViewsHandlerFilterBoolean::value_form() should be compatible with that of SearchApiViewsHandlerFilter::value_form() in _registry_check_code()

I have used registry rebuild drush module and I use the latest dev release of search api module.

CommentFileSizeAuthor
#2 search_api.patch2.37 KBJohnny vd Laar
#1 1294828--die,-coding-standards,-DIE!.patch1.37 KBdrunken monkey

Comments

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Strict warning: Declaration of SearchApiViewsHandlerFilterBoolean::value_form() should be compatible with that of SearchApiViews » Deal the fatal blow to OOP coding standards in Views integration
Component: Miscellaneous » Views integration
Status: Active » Needs review
StatusFileSize
new 1294828--die,-coding-standards,-DIE!.patch1.37 KB

Sorry, I thought I had already weeded out all remaining traces of OOP coding standards in the Views integration code. Seem to have missed two places.
Please try the attached patch.

Johnny vd Laar’s picture

Johnny vd Laar commented
StatusFileSize
new search_api.patch2.37 KB

No the problem is still there. I've ran the following patch as I found 2 other occurrences of the line you modified. But it didn't help.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

But it didn't help.

What notices are there now? Or still the same?

I didn't modify the field handlers as they will be removed in the next few days anyways – see #1231512: Use real Relationships instead of level magic in Views integration. So if the notices are from the field handlers, just wait a few days.

Johnny vd Laar’s picture

Johnny vd Laar commented

no it's still the same filterhandler error that I get:
Strict warning: Declaration of SearchApiViewsHandlerFilterBoolean::value_form() should be compatible with that of SearchApiViewsHandlerFilter::value_form() in _registry_check_code() (line 2701 of /home/johnny/www/rm-drupal/includes/bootstrap.inc).

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Then you applied the patch wrong. Or, you're possibly using a very old module version, but I don't think that's it.

Johnny vd Laar’s picture

Johnny vd Laar commented
Status: Needs review » Reviewed & tested by the community

You are right I applied the patch wrong. It works now! Sorry for the misunderstanding and thanks a lot!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.