geocode_exif_field() seems to be evaluating the geofield (type: text) and not the referenced field (type: image) form what i can see in my debugger.

I have no immediate need for this (admittedly cool) functionality but discovered it as part of the module testing im doing to make a release for this thing.

Anyone care to lookinto it or provide a pointer as to what might be wrong?

Attaching an image I found with GPS locative data as a reference test image. This image has been tested with exif (ubuntu) and i can confirm that lat lon data is stored in the exif.

CommentFileSizeAuthor
#3 exif-fix.patch1014 bytesmichaelfavia
IMG_4692.jpg610.1 KBmichaelfavia

Comments

phayes’s picture

phayes commented

Does it work if you just call geocode('exif','/path/to/image.jpg'); ?

michaelfavia’s picture

michaelfavia commented

Yes: result:

Point Object
(
    [position:Point:private] => Array
        (
            [0] => -116.30161960178
            [1] => 33.87546081543
        )

    [geom_type:protected] => Point
    [geos:Geometry:private] => 
    [srid:protected] => 
)

Edit: this is the correct location. ;)

michaelfavia’s picture

michaelfavia commented
StatusFileSize
new exif-fix.patch1014 bytes

Traced it down in the debugger.

Geocoder.module:255
Expects to be able to return $item['value'] as the path to the image but it is undefined for image fields.

The rest of the call fails as expected. Attached patch special cases the image and file. review welcome before commit. just starting to get my head around this module and might be short changing the design.

michaelfavia’s picture

michaelfavia commented
Status: Active » Needs review

Needs review. sorry for bug spam.

phayes’s picture

phayes commented
Status: Needs review » Reviewed & tested by the community

I reviewed, but didn;t test. If it works then commit it!

michaelfavia’s picture

michaelfavia commented
Status: Reviewed & tested by the community » Closed (fixed)

Done and done.