Currently the tab titles are set from the plugin info hook, which is/can be cached. The titles *should* be set from the view/render step which would allow Views with arguments to override the title.

CommentFileSizeAuthor
#2 1292932-2-media-override_media_browser_tab_title.patch1.49 KBbecw

Comments

becw’s picture

becw commented
Assigned: Unassigned » becw

If we add a title() callback to the new media browser plugin class, we can use that to determine plugin titles. We can provide a default implementation that just returns the plugin's 'title' property from the info hook.

becw’s picture

becw commented
Assigned: becw » Unassigned
Status: Active » Needs review
StatusFileSize
new 1292932-2-media-override_media_browser_tab_title.patch1.49 KB

Here's a patch that I think addresses this issue. Plugins can set a tab title in the plugin info array or use custom logic in their class's title() method. The plugin output is run through hook_media_browser_plugins_alter() as usual (we did discuss changing this so that a drupal_alter() gets called the output of one plugin at a time, but I haven't touched that), and ultimately the #title property of the plugin output is used as the tab title. Does this give us enough to work with?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Component: Code » Media Browser
Assigned: Unassigned » dave reid

Assigning to myself for review.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

After the Media browser cleanup has landed, I committed something like this but implemented in the view() method to allow the title to be changed: http://drupalcode.org/project/media.git/commit/bfa3ac9

Automatically closed -- issue fixed for 2 weeks with no activity.