Split off from #493074: Back-link to the commit as a comment on the related issue..

Possible methods for marking an issue as fixed via a commit:

  • Provide per-project setting that marks issues as fixed when related commit is made. Most of contrib tends to work this way, but we can simply default to false just to be safe.
  • Use special syntax in commit message for closing issues (or git notes) such as github style "closes #".

Or of course, not at all.

Comments

dww’s picture

dww
we/he/they
commented

I prefer special syntax over a per-project setting (even if it defaults to false). I don't think we want to be automatically marking things fixed on every commit. The human should somehow decide the issue is fixed or not on a case-by-case basis, and either reply at the issue themselves, or at least format their commit message to indicate they intend for the issue to be closed.

In terms of the specific syntax, seems reasonable to adopt the de facto Github standard.

Although "closes #x ..." is not as ideal for harvesting commits when writing release notes (e.g. with http://drupal.org/project/grn). For that "fixed #x" would be better. Maybe we should just support a couple of different prefixes and give maintainers freedom to decide how they want to use this. Or maybe we should patch grn to re-write "closes #x" to "Fixed #x" (or just "#x") or something. ;)

Anyway, this would be a slick feature, and should be quite easy to implement once #493074: Back-link to the commit as a comment on the related issue. lands. I'd normally call this "postponed" since no one should start writing code for this until #493074 is in -- but in this case it seems okay to leave the issue open for further discussion on syntax vs. setting, and what syntax we want assuming we're going to go that route.

Thanks,
-Derek

markhalliwell’s picture

markhalliwell
Primary language English
commented

Would really love to see this, FWIW I usually almost always use "Fixes [#...] - Title" when I submit a patch.

hass’s picture

hass commented
Issue summary: View changes

I'm against closing issues without a special syntax.

I make tons of commits to #1948588: Google Analytics 8 upgrade and this issue should not be closed automatically.

marvil07’s picture

marvil07 commented
Version: 6.x-2.x-dev » 7.x-1.x-dev

Special syntax sounds fine, and now that there is a way to react to code changes(see #1796144: Add a "event processor" plugin type for repositories), it should be straight forward as a new plugin.
I'm not sure this should be added on d.o, but I'm ok to add it to the module.

Also moving version.

Patches welcome.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Active » Closed (duplicate)
Related issues: +#1291886: Support marking an issue as fixed via a commit

Despite this issue being technically older, there is more traction/discussion in related issue.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Related issues: -#1291886: Support marking an issue as fixed via a commit +#2270763: Automatically fix issues when commit message contains "Fixed …" keyword (powerful/smart commit messages)

C&P ftw!