Machine name on menu add form is wrong [#1288910]

When adding a menu ( admin/structure/menu/add ) you get the machine name from the title input field, using misc/machine-name.js. The actual machine name that is stored in the database adds 'menu_' as a prefix to the visible machine name on the form though (as visible if you save the menu and then edits it to see the machine name).

My thought is that an extra string argument 'prefix' could be added to the call to Drupal.behaviors.machineName.attach that will be added to the machine name, then the menu module could be updated to send 'menu' as a prefix when calling machineName.attach ($form['menu_name'] in menu.admin.inc).

Comment	File	Size	Author
#12	add_menu_to_machine_name-1288910-12.patch	519 bytes	tinko
#12	7.x: PHP 7 & MySQL 5.5 2,035 pass
#9	add-menu-machine-name-1288910-9.patch	1.19 KB	Rajender Rajan
#9	7.x: PHP 5.3 & MySQL 5.5 1,932 pass, 120 fail
#5	add_menu_machine_name-1288910-5.patch	2.78 KB	FreddieK
#5
#3	add_menu_machine_name-1288910-3.patch	1.67 KB	FreddieK
#3
#1	add_menu_machine_name-1288910-1.patch	1.14 KB	FreddieK
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

FreddieK CreditAttribution: FreddieK commented 23 September 2011 at 15:17

File	Size
add_menu_machine_name-1288910-1.patch	1.14 KB

Here's a patch that does what's outlined above:

(not working, see next comment)

Comment #2

FreddieK CreditAttribution: FreddieK commented 23 September 2011 at 15:12

I noticed that the patch has the unlucky result that 'menu-' now gets added twice to the machine name, so no disco. But is the approach a good one or should this be solved in a different way?

Comment #3

FreddieK CreditAttribution: FreddieK commented 23 September 2011 at 15:21

File	Size
add_menu_machine_name-1288910-3.patch	1.67 KB

Fixed patch.

Comment #4

joachim CreditAttribution: joachim commented 24 September 2011 at 14:23

Version:	7.8	» 7.x-dev
Status:	Active	» Needs work

This seems like a good idea, but this new key needs to be added to the documentation for Drupal.behaviors.machineName.

Some other points:

+++ b/misc/machine-name.js
@@ -111,8 +111,14 @@ Drupal.behaviors.machineName = {
+    ¶

Remember to trim whitespace.

+++ b/misc/machine-name.js
@@ -111,8 +111,14 @@ Drupal.behaviors.machineName = {
     return source.toLowerCase().replace(rx, settings.replace).substr(0, settings.maxlength);

This needs indenting.

+++ b/modules/menu/menu.admin.inc
@@ -556,8 +557,6 @@ function menu_delete_menu_confirm_submit($form, &$form_state) {
-  // 'menu-' is added to the menu name to avoid name-space conflicts.

Move this comment to the 'prefix' item, as the reason we need a prefix still needs explaining.

4 days to next Drupal core point release.

Comment #5

FreddieK CreditAttribution: FreddieK commented 7 October 2011 at 09:30

File	Size
add_menu_machine_name-1288910-5.patch	2.78 KB

Updated patch.

Comment #6

Bathie CreditAttribution: Bathie commented 22 February 2012 at 17:03

Hello, I tested the patch, it is good

Comment #7

mgifford

he/him

English

CreditAttribution: mgifford commented 15 February 2013 at 12:43

Status:

Needs work

» Needs review

Pushing to needs review. I think that's what's missing here.

Comment #8

15 February 2013 at 12:50

Status:

Needs review

» Needs work

The last submitted patch, add_menu_machine_name-1288910-5.patch, failed testing.

Comment #9

Rajender Rajan CreditAttribution: Rajender Rajan as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 30 November 2016 at 09:12

Issue summary:

View changes

File	Size
add-menu-machine-name-1288910-9.patch	1.19 KB
7.x: PHP 5.3 & MySQL 5.5 1,932 pass, 120 fail

Comment #10

Rajender Rajan CreditAttribution: Rajender Rajan as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented 30 November 2016 at 09:13

Status:

Needs work

» Needs review

Comment #11

30 November 2016 at 09:31

Status:

Needs review

» Needs work

The last submitted patch, 9: add-menu-machine-name-1288910-9.patch, failed testing.

Comment #12

tinko CreditAttribution: tinko as a volunteer commented 14 September 2017 at 20:23

Status:

Needs work

» Needs review

File	Size
add_menu_to_machine_name-1288910-12.patch	519 bytes
7.x: PHP 7 & MySQL 5.5 2,035 pass

Hello,

In misc/machine-name.js has a short documentation about the properties and there is already field_prefix that will show before menu name if the #field_prefix is added to field "menu_name".

Greetings

Comment #13

ethomas08 CreditAttribution: ethomas08 as a volunteer commented 16 October 2018 at 18:37

Is this issue the same as this one?? https://www.drupal.org/project/drupal/issues/2021571
The patch for the other issue looks good. It adds the menu- to the menu name when adding a new menu.

Comment #14

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented 11 September 2022 at 19:24

Status:	Needs review	» Closed (duplicate)
Related issues:		+#2021571: preview of menu machine name is inaccurate on while adding a menu (does not show it will be saved with menu- prefix)

This is indeed a duplicate of #2021571: preview of menu machine name is inaccurate on while adding a menu (does not show it will be saved with menu- prefix) and it should be fixed in 7.92 release. Thanks!