The onecol panels are missing a width declaration (also used to set default margins on either side of the column).

patch to follow...

CommentFileSizeAuthor
#11 omega-onecol-grid-declaration-1282808.patch1.81 KBjwilson3
#9 omega-onecol-grid-declaration-1282808.patch1.81 KBjwilson3
#7 omega-onecol-grid-declaration-1282808.patch1.78 KBjwilson3
#1 omega-onecol-grid-declaration-1282808.patch2.09 KBjwilson3
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
Status: Active » Needs review
FileSize
omega-onecol-grid-declaration-1282808.patch2.09 KB
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented

This patch is needed with #1245428: panels layouts break column alignment, otherwise single-column panels that are added into a page via the block system, will sit slightly outside the grid guides, having expanded to the negative margin provided by that patch.

Cellar Door’s picture

Cellar Door CreditAttribution: Cellar Door commented
Assigned: Unassigned » fubhy

Was this fixed with the latest dev release?

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented

@Cellar Door: No, this has not been fixed in git yet.

Status: Needs review » Needs work

The last submitted patch, omega-onecol-grid-declaration-1282808.patch, failed testing.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
Status: Needs work » Needs review

While looking at these minor panels fixes, there is also one other small class error I've provided a patch for on #1447066: Panel pane classes in omega 12 column set margin to zero.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
FileSize
omega-onecol-grid-declaration-1282808.patch1.78 KB

Reroll, to remove sites/all/themes/omega from the patchfile :-/ sorry.

Status: Needs review » Needs work

The last submitted patch, omega-onecol-grid-declaration-1282808.patch, failed testing.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
Status: Needs work » Needs review
FileSize
omega-onecol-grid-declaration-1282808.patch1.81 KB

heres another try :-/

Cellar Door’s picture

Cellar Door CreditAttribution: Cellar Door commented
Status: Needs review » Patch (to be ported)

Let's add this to the 3.2 release

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
FileSize
omega-onecol-grid-declaration-1282808.patch1.81 KB

The last patch is borked.

+++ b/omega/panels/layouts/omega_16/omega_16_onecol/omega-16-onecol.tpl.php
@@ -1,5 +1,5 @@
 <div class="panel-display omega-grid omega-16-onecol" <?php if (!empty($css_id)) { print "id=\"$css_id\""; } ?>>
-  <div class="panel-panel">
+  <div class="panel-panel grid-12">

should be grid-16 there. #facepalm.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
Status: Patch (to be ported) » Needs review
pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
CreditAttribution: pingwin4eg commented

#11: omega-onecol-grid-declaration-1282808.patch queued for re-testing.