Closed (fixed)
Project:
Maestro
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Sep 2011 at 05:59 UTC
Updated:
19 Nov 2014 at 17:05 UTC
Jump to comment: Most recent
When someone tries to use "Regenerate all", a database exception appears, because:
$q3 = db_select('maesto_queue_from','a');
$q3->addField('a','from_queue_id');
$q3->condition("a.queue_id = {$active_queue_record->id}");
$queue_reporting_result = $q3->execute();
foreach ($queue_reporting_result as $queue_reporting_record) {
$record = new stdClass();
$record->id = $queue_reporting_record->from_queue_id;
$record->process_id = $new_processid;
drupal_write_record('maestro_queue',$record);
}
in maestro_engine_version1.class.php, line 160, inside MaestroEngineVersion1::newProcess();
1) It has a typo: "maesto_queue_from" instead of "maesto_queue_from". It raises an exception.
2) The drupal_write_record tries to include the ->id, which is primary key, without specifying that it's an update. It raises an exception (at least in some cases).
Comments
Comment #1
imaizumi commentedI am using the maesrto module in my drupal system.
Thank you for creating the useful module.
I read following article.
Maestro Module: To Regenerate or Not To Regenerate...
http://www.nextide.ca/maestro-regeneration
And, I tried a workflow checked Regenerate All In Production Tasks flag.
But, It did not work because of this reported bugs.
If possible, please fix it.
Thank you.
Comment #2
_randy commentedFixed the typo in git.
Comment #3
imaizumi commentedThank you for fixing typo.
But, the following report is reproduced.
>2) The drupal_write_record tries to include the ->id, which is primary key, without specifying that it's an
update. It raises an exception (at least in some cases).
Comment #4
_randy commentedCommitted a fix to dev.
Comment #4.0
_randy commentedadded details on the code quote, where to find it
Comment #6
blainelang commented