Features support for languages

Your patch is empty :)

Tagging

I got this error when enabling a feature:
PDOException: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'plurals' at row 1: UPDATE {languages} SET plurals=:db_update_placeholder_0, formula=:db_update_placeholder_1 WHERE (language = :db_condition_placeholder_0) ; Array ( [:db_update_placeholder_0] => [:db_update_placeholder_1] => [:db_condition_placeholder_0] => fi ) in _features_language_save() (line 138 of /www/sites/all/modules/contrib/features/includes/features.locale.inc).

Using

• Drupal 7.8
• features 7.x-1.0-beta4 with the patch #3
• MySQL 5.1.41

+++ b/includes/features.locale.inc
@@ -0,0 +1,160 @@
+        'plurals' => empty($language->plurals) ? '' : $language->plurals,

The default value should probably be '0' instead of '', adding a new patch.

I didn't experience the error from #6 myself, but that's because I was testing a language which has plurals set to 2.

@derhasi: Yes, the 0 is better.

I think that this is ready...

Minor coding standards issue; have you run the file through coder?

+++ b/includes/features.locale.inc
@@ -0,0 +1,160 @@
+      // Add language to exports

Missing .

+
+ // No pipe.
+ $pipe = array();
+ return $pipe;

This isn't against coding standards, but it just looks odd. I'd either put $pipe at the top, or return array();

+++ b/includes/features.locale.inc
@@ -0,0 +1,160 @@
+    if (array_key_exists($name, $language_list)) {

Not against coding standards again, but tmk array_key_exists is slower and not as useful as !empty($language_list[$name]); for example, $language_list could be array('blah' => '') and array key exist would return true, despite blah being ''.

+++ b/includes/features.locale.inc
@@ -0,0 +1,160 @@
+    // Rebuild locale javascript hashs.
+    //_locale_rebuild_js($language->language);

Commented out code? :(

+++ b/includes/features.locale.inc
@@ -0,0 +1,160 @@
\ No newline at end of file

New line!

Great, still works as expected :)

#8 works for me

The patch in #11 applies cleanly and works as expected. Great work Johannes!

+1 RTBC

I would like to find a hook to add some code after reverting/rebuilding a feature.
For example, it would be nice to run l10n_update after importing new languages.

I tried

/**
 * Implements hook_enable().
 */
function my_feature_enable() {
  l10n_update_modules_enabled(module_list());
}

but it does not work :/

Committed 1027e94

mpotter, it seems you forgot the include file :)

New patch with the remaining includes/features.locale.inc file.

Ack. Just forgot to add the include file to git. Committed with include file f6ff815.