It would be bad form to have the Meta tags vertical tab without a summary. We should provide a summary of overridden meta tags only, and if not meta tags have been overridden, display 'Using default meta tags').

CommentFileSizeAuthor
#1 1277962-vertical-tabs-summaries.patch3.26 KBdave reid

Comments

dave reid’s picture

Status: Active » Needs review
StatusFileSize
new3.26 KB

Initial vertical tab summary that skips a summary for any meta tags that equal their default values.

Using default values:
Only local images are allowed.

Overriding some values:
Only local images are allowed.

Value too long for summary:
Only local images are allowed.

dave reid’s picture

Status: Needs review » Fixed
yoroy’s picture

That you used 'Overridden description' as the example string tricked me for a bit, but yes, this smells good.

Some additional feedback on the ui text, trying to use some simpler words here and there:

Only local images are allowed.

For "The description of the page in the crawlers that support the tag" I was thinking that maybe crawlers is a bit too jargonny. Something like "This description is used by certain search engines to index your page" maybe? The person who installs this module might well *not* be the person who will fill this out, so best talk to our dear content creater here I think.

dave reid’s picture

Ok I didn't want you to read the descriptions on the meta tags as they're pretty horrible and being re-visited this week. :)

pbull’s picture

It might be valuable to have the default value/token listed in the description for each field, so there's an easy reference for the user to go back to using the default value if they later decide to remove the overridden value.

Automatically closed -- issue fixed for 2 weeks with no activity.