eval is odd choice here; backporting drupal_array_set_nested_value as realname_array_set_nested_value seems like a better path

Patch done quickly, not exactly tested. Didn't backport the giant comment for that function as it seemed to dominate the module.

CommentFileSizeAuthor
#1 1276980-remove-eval.patch1.38 KBDave Reid
realname_remove_eval.patch1.41 KBhefox
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Version: 6.x-1.4 » 6.x-1.x-dev
FileSize
1276980-remove-eval.patch1.38 KB

Revised patch:
1. Removes the 'array' type hints from the backport function (this would have failed PHP 4 which doesn't support type hinting).
2. Adds '#default_value' into the parents array.

I tested this just with some sample code and it works as intended.

Status: Needs review » Needs work

The last submitted patch, 1276980-remove-eval.patch, failed testing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Fixed

Duh - there were no tests to run. Thanks testbot. Committed #1 to Git. http://drupalcode.org/project/realname.git/commit/a042dcb

Thanks hefox!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.