Closed (fixed)
Project:
Commerce Core
Version:
7.x-1.x-dev
Component:
Payment
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Sep 2011 at 17:57 UTC
Updated:
4 Jan 2014 at 01:11 UTC
Jump to comment: Most recent
Comments
Comment #1
Bojhan commentedLooks good, converting numbers to the corresponding month is strangely enough not a thing our brain does seamlessly. Given that in this particular instance you would most likely go from your card or for our more intermediate/expert shoppers by memory - this would be a good change.
Comment #2
rszrama commentedAlrighty, gave this a review. We need to preserve the two digit and four digit year because that's how it currently works (and what most payment gateways expect to receive). Also, I added a span around the / between the month and year so it can more easily be targeted for theming. By default, I'm just tacking a 3px margin to the right so it pads properly with the year select in relation to the month select.
Commit: http://drupalcode.org/project/commerce.git/commitdiff/a83745b