#prefix and #suffix doesn't work with jquery_colorpicker

Hello

First of all, thanks for your interest in the jquery_colorpicker module.
About you request, you're right, because as you can see on the line 157 of the jquery_colorpicker.module file

if (isset($element['#field_prefix']))
{
	$output .= '<span class="field-prefix">'. $element['#field_prefix'] .'</span> ';
}

the preffix (and suffix in the same way) text is included into a <span> tag. It could break your layout.

However, I propose you a new layout for your based, simpler and cleaner. You can implement a code similar to

function jquery_test(){
  
	$range = range(1,7);
	
	foreach($range as $key => $value){
		$options[$key]['index']['data'] = array(
          '#type' => 'select',
          '#options' => drupal_map_assoc(range(1,3)),
          '#required' => TRUE,
        );
    $options[$key]['color']['data'] = array(
          '#type' => 'jquery_colorpicker',
          '#required' => TRUE,
        );	 
        
        $options[$key]['background']['data'] = array(
          '#type' => 'jquery_colorpicker',
          '#required' => TRUE,
          '#default_value' => 'FABADA',
        );
	}
	
	$header = array(
    'index' => array('data' => t('index')),
    'color' => array('data' => t('Color')),
    'background' => array('data' => t('Background')),
	   
  );
	
	$form['placement'] = array(
      '#theme' => 'table',
      '#header' => $header,
      '#rows' => $options,
      '#empty' => t('No content available.'),
    );
    
	return $form;
}

Which is displayed as you can see in the attached image.

However, creating this example I found another bug in the module when creating this kind of layouts. I commited it, but I'm attaching the diff file too.
Thank you very much for your interest and I will take into account the <span> tag for preffix and suffix in a near future.

Best Regards

Hello

I don't know if your memory problem is due to the Drupal's way to theme tables. However, I think that this method is better than prefix and suffix. Moreover, this is the way used by Drupal core modules to display tables, for example in the admin/content page.

If you're sure that your problems will be solved removing the span tag, remove it form code!
You can hack the module and remove it from line, converting:

if (isset($element['#field_prefix']))
{
    $output .= '<span class="field-prefix">'. $element['#field_prefix'] .'</span> ';
}

in

if (isset($element['#field_prefix']))
{
    $output .=  $element['#field_prefix']';
}

and the same for suffix line.

Please, try it and give me feedback about it!

Good Luck and thanks for your effort.

Regards

Hi
I'm really surprised with that behavior.
Are you sure that it is a jquery_colorpicker form item problem?
Could you try to change the jquery_colorpicker items and place i.e. textfields?
Maybe it is a problem related to the table structure instead of jquery_colorpicker implementation...

I don't know... :(

Good Luck!

Hi

It looks definitely like a jquery_colorpicker bug :(

However, given that it works fine for textfields, you can try to debug the theme function for jquery_colorpicker, on jquery_colorpicker. module file on line 70.

Debug if each colorpicker widget is themed OK or if something is wrong there. Or try to debug a simpler table to try to detect the bug in an easier way.

At the moment I don't know where the problem could be placed :(

Good Luck and give me feedback, please

The problem could not be reproduced, and other tests worked fine.

However, if somebody can help on this issue, it will be welcome.

Regards

This should be fixed in last released version.
Thank you for your help.
Fell free to reopen this if your problems persist.