See #91267: Request for X-FEN support.

CommentFileSizeAuthor
#12 chessboard-empty-squares-1269424-12.patch532 byteseric_a
#11 chessboard-empty-squares-1269424-11.patch861 byteseric_a
#9 chessboard-empty-squares-1269424-9.patch582 byteseric_a
#6 chessboard-empty-squares-1269424-6.patch530 byteseric_a
#3 chessboard-empty-squares-1269424-3.patch1.2 KBeric_a
#1 chessboard-empty-squares-1269424-1.patch1.2 KBeric_a

Comments

eric_a’s picture

eric_a commented
Status: Active » Needs review
StatusFileSize
new chessboard-empty-squares-1269424-1.patch1.2 KB

Needs work, but let's see how we're doing.

Status: Needs review » Needs work

The last submitted patch, chessboard-empty-squares-1269424-1.patch, failed testing.

eric_a’s picture

eric_a commented
Status: Needs work » Needs review
StatusFileSize
new chessboard-empty-squares-1269424-3.patch1.2 KB
eric_a’s picture

eric_a commented
Status: Needs review » Needs work
Issue tags: +Needs tests
eric_a’s picture

eric_a commented

We need a test for the new stuff. Maybe testing something like "10/pppppppp1p/10/9p".

So #1 broke our "8/3x1x2/2x3x1/4N3/2x3x1/3x1x2/8/8" test, which was mostly there for marked squares.
Before adding "9" and "10" I'd like to add another test first that captures some of the existing behavior. Maybe something like "ppppppp1/8".

eric_a’s picture

eric_a commented
Status: Needs work » Needs review
StatusFileSize
new chessboard-empty-squares-1269424-6.patch530 bytes

After recent refactorings, this has become a trivial change.

eric_a’s picture

eric_a commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Fixed

Pushed to 7.x-2.x and 6.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

eric_a’s picture

eric_a commented
Version: 6.x-2.x-dev » 8.x-2.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new chessboard-empty-squares-1269424-9.patch582 bytes

After recent refactorings, this has become a trivial change.
And broken code was pushed still...

eric_a’s picture

eric_a commented
Version: 8.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Fixed

Pushed #9 to 8.x-2x, 7.x-2x, 6.x-2.x.

eric_a’s picture

eric_a commented
Version: 6.x-2.x-dev » 8.x-2.x-dev
Status: Fixed » Needs review
StatusFileSize
new chessboard-empty-squares-1269424-11.patch861 bytes

The last patch fixes the processing of "9" and "10" but introduces an issue when it comes to strings like "20". We don't want to try rendering "0".

eric_a’s picture

eric_a commented
StatusFileSize
new chessboard-empty-squares-1269424-12.patch532 bytes

This patch is smaller and leaves the regex and processing order alone.

eric_a’s picture

eric_a commented
Status: Needs review » Fixed

Pushed #12 to 8.x-2.x, 7.x-2.x, 6.x-2.x.

eric_a’s picture

eric_a commented
Version: 8.x-2.x-dev » 6.x-2.x-dev

Automatically closed -- issue fixed for 2 weeks with no activity.