Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
more cruft to be removed; not being used anymore:
media_url_filter and _media_url_parse_full_links functions.
Comment | File | Size | Author |
---|---|---|---|
#2 | remove_unneeded_code-1268268-2.patch | 2.69 KB | idflood |
Comments
Comment #1
aaron CreditAttribution: aaron commentedand _media_url_curry as well (all from /includes/media.filter.inc)
Comment #2
idflood CreditAttribution: idflood commentedHere is a simple patch which remove these functions. I've double checked that they weren't used anywhere and verified some more functions.
Comment #3
dddave CreditAttribution: dddave commented#2: remove_unneeded_code-1268268-2.patch queued for re-testing.
Comment #4
Devin Carlson CreditAttribution: Devin Carlson commentedI searched through the Media codebase and
media_url_filter()
is no longer called anywhere. The function also has two helper functions_media_url_parse_full_links()
and_media_url_curry()
.The patch in #2 still applies cleanly to 7.x-2.x-dev and removes the three functions.
Comment #5
Dave ReidOk confirmed as well. I removed the code and moved it to a Gist: https://gist.github.com/3020238 so that we still have it somewhere in case we need to bring it back or someone else wants to use it.
Comment #6
Dave ReidCommitted #2 to 7.x-2.x. I also marked the 7.x-1.x functions as officially deprecated.
http://drupalcode.org/project/media.git/commit/1d3f52f1 (7.x-2.x)
http://drupalcode.org/project/media.git/commit/93b4d71 (7.x-1.x)