dog-init options can be hard to remember so lets make it ask the user questions and recommend defaults for all the options.

CommentFileSizeAuthor
#8 dog-init-interactivity-1265844-6.patch7.57 KBtimhilliard
#5 dog-init-interactivity-1265844-4.patch8.56 KBtimhilliard
#3 dog-init-interactivity-1265844-2.patch11.44 KBtimhilliard
#1 dog-init-interactivity-1265844.patch2.73 KBtimhilliard

Comments

timhilliard’s picture

timhilliard commented
Status: Active » Needs review
StatusFileSize
new dog-init-interactivity-1265844.patch2.73 KB

This patch allows the user to interactively set upstream, upstream-ref, branch and collab when using dog-init. The options disappear if they are used in the command line in the first place.

sdboyer’s picture

sdboyer commented
Status: Needs review » Needs work

Yeah, not too tough. Cool. Thing is, though, could you re-roll against the oo-core branch? master is dead until I merge that branch back in.

nit:

+++ b/dog.drush.inc
@@ -376,7 +376,8 @@ function dog_autoload($class) {
+  $upstream = drush_get_option('upstream', drush_prompt('upstream repository', 'drupal', true));

Drupal coding standards dictate that boolean keywords are in all caps - s/true/TRUE/.

timhilliard’s picture

timhilliard commented
Status: Needs work » Needs review
StatusFileSize
new dog-init-interactivity-1265844-2.patch11.44 KB

Alrighty, re-rolled patch against core as well as moving validation options into validation hook.

timhilliard’s picture

timhilliard commented

Ok read group post about dog roadmap, possibly got the hint :). I was probably a bit tired when I rolled this patch. I'll have a thorough look over it tomorrow and re-roll it again when I'm not so tired.

timhilliard’s picture

timhilliard commented
StatusFileSize
new dog-init-interactivity-1265844-4.patch8.56 KB

Ok re-rolled patch with better formatting and comments

sdboyer’s picture

sdboyer commented

Finally got back to some dog work tonight, and realized there were a dozen commits I hadn't pushed up. ...yikes. Sorry. So now, patch doesn't apply :( reroll, if you could? I'm now very ready to bring this in - don't want to move on to implementing the House until after I've got this.

sdboyer’s picture

sdboyer commented
Status: Needs review » Needs work
timhilliard’s picture

timhilliard commented
Status: Needs work » Needs review
StatusFileSize
new dog-init-interactivity-1265844-6.patch7.57 KB

ok took me a while to sort this out but got there eventually. so attached is re-rolled patch.

sdboyer’s picture

sdboyer commented
Status: Needs review » Needs work

OK, committed this. There's definitely still a ways to go before I'm 100% happy with it, but I'd rather have the basics in and work from there than dilly dally. We can fix and improve it as we go.

sdboyer’s picture

sdboyer commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.