The function webform_update_6329 in webform.install does not return $ret at the end of the function, and so updating causes the following error:

warning: array_merge() [function.array-merge]: Argument #2 is not an array in update.php on line 173.<br />
warning: Invalid argument supplied for foreach() in update.php on line 337.
CommentFileSizeAuthor
#2 webform_update_bug.png38.51 KBgoose2000

Comments

tjg’s picture

tjg commented

Here's a diff to fix the problem:

--- webform.install	(revision 537)
+++ webform.install	(working copy)
@@ -1488,4 +1488,6 @@
   );
 
   db_create_table($ret, 'webform_last_download', $schema['webform_last_download']);
+
+  return $ret;
 }
goose2000’s picture

goose2000 commented
StatusFileSize
new webform_update_bug.png38.51 KB

I just tried to update using:

webform-6.x-3.13.tar.gz

and I got some errors/warnings, see attached.
Is it broke now?

vernond’s picture

vernond commented
Status: Active » Fixed

Apologies for my finger trouble folks! This error has been fixed in 6.x-3.14 which is ready for download on the webform home page.

@tjg - thanks for the prompt report and patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.