More forms to select for protections

First thanks for the module. I love the ingenuity of it! I was needed to use it to protect my comment forms and some webforms i had made. So i checked the protect all forms. But then i noticed that is was stopping the search form from being input. So i needed a way to remove the search form and only select the forms that i wanted. SO i dug into the code and laughed when i saw this:

/**
 * Build an array of all the protected forms on the site, by form_id.
 *
 * Currently only works for user_register_form. Pfft!
 *
 * @todo - Build query dynamically, using db_select...
 */

So after some tinkering, i came up with this. I know its not the easiest way, but it works for me. In the honeypot.admin.inc file on line 51 there is a checkbox to enable protection for the user registration form. I copied and pasted this a couple times for each type of form i wanted to protect. To set the variable name i went and got the form id from each form i wanted to protect. Then i added "honeypot_form_" to the beginning of it (***this is important***).

$form['enabled_forms']['honeypot_form_search_block_form'] = array(
      '#type' => 'checkbox',
      '#title' => t('Search Form'),
      '#default_value' => variable_get('honeypot_form_search_block_form', 0),
    );
	$form['enabled_forms']['honeypot_form_comment_node_article_form'] = array(
      '#type' => 'checkbox',
      '#title' => t('Article Comment Forms'),
      '#default_value' => variable_get('honeypot_form_comment_node_article_form', 0),
    );

This gives me checkboxes and sets variables for each form ID i needed.

On to honeypot.module...

Then i needed to make the form show up when these forms are rendered. So in order to get the form ID that i wanted, i needed to query the variable table and pull out any variables that started with "honeypot_form_". After i got the list of variables i needed to see if they were set, and if so return the form ID. After iterating through the list of forms, i needed to return an array of form IDs. (Im sure there is a better way to do it, but im not exactly a professional coder.)

function honeypot_get_protected_forms() {
	$forms = array();
	$result = db_select('variable', 'v')
    ->fields('v')
    ->condition('name', db_like('honeypot_form') . '%', 'LIKE')
    ->execute()
    ->fetchCol();
	
  foreach($result as $record){
	  if(variable_get($record) == 1){
		  $needle = 'honeypot_form_';
		  $form_id = str_replace($needle, '',$record);
		  array_push($forms, $form_id);
	  }
  }
  return $forms;
}

I have attached a patch for the module file. I figured since everyone is gong to want to protect different forms, they can just copy the snippet above and replace what they need to.

Like i said, i am NOT a coder, and there is probably better, more drupalish ways of doing this, but this works for me.

Have fun, and again, thanks for the module.