Problem:
Adding a "Context Exists" visibility rule to a content pane grants grants access if ANY context exists, not just if the selected context exists.

To reproduce:
1. Add an optional term reference field to a content type
2. Enable the node_view panel page
3. add a context relationship to the panel page term reference field created in step 1
4. Add a content pane (anything is fine)
5. Add a "Context Exists" visibility rule to that content pane and select the term reference relationship context you added in step 3.
6. View a node that doesn't have a taxonomy term selected (for the field from step 1) and notice that the content pane is visible even though
it's configured to be visible only if the taxonomy term context exists.

[Update]
Latest patch in Comment #11

CommentFileSizeAuthor
#11 ctools-context-exists-access-plugin-1263896-11.patch2.01 KBsetvik
#10 ctools-context-exists-access-plugin-1263896-8.patch2.01 KBsetvik
#8 ctools-context-exists-access-plugin-4923364-3.patch614 bytessetvik
#3 ctools-context-exists-access-plugin-4923364-3.patch614 bytessetvik

Comments

setvik’s picture

setvik commented
Title: "context exists" access plugin broken? » "context exists" access plugin broken
setvik’s picture

setvik commented
Title: "context exists" access plugin broken » "context exists" access plugin broken (patch)
setvik’s picture

setvik commented
StatusFileSize
new ctools-context-exists-access-plugin-4923364-3.patch614 bytes

[UPDATE]

The attached patch doesn't work. Don't use it

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Needs review

The 'any' just means that any context can be used to satisfy the condition.

Though hmm. I suppose fallback code to try and match up contexts that have been renamed might actually be at issue here. Are you 100% sure that actually fixes the problem? It still allows any context to actually be selected?

setvik’s picture

setvik commented

Here's what i found so far:

The patch above definitely fixed the issue i was having and made it so that the "context exists" visibility rule returned true only when the context specified in the rule configuration existed.

Before removing the "any" the context exists rule was returning TRUE in the node_view panel regardless of whether the context i had specified existed or not.

I tried debugging and found that if the specified context exists ctools_context_required::select() returns that context as expected.

But if the context isn't present, ctools_context_required::select() does the fallback you mentioned looking for contexts with changed IDs.
It delegates this to ctools_context_required::filter() which runs through all present contexts and returns any matching the "required" context specified in the plugin configuration (in context exists' case, that's "any" which all contexts will match), so ctools_context_required::filter() ends up returning the unwanted node_view node context (in my case).

I've only tested so far with the taxonomy term context that i added to my node_view panel.

I'll test it with some other contexts and get back with the results.

setvik’s picture

setvik commented

ackk... you're right.

the patch only fixed the problem b/c I added the visibility rule before making the patch...

I just tried removing the visibility rule and now the "context exists" visibility rule option doesn't even appear...

"I suppose fallback code to try and match up contexts that have been renamed might actually be at issue here."

Yeah, that seems to be what was causing my problem. i'm not sure how to fix it though...

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

Probably an extra parameter to the ctools_context_required object with a way to say not to fall back to another context.

The fallback code is in ctools_content_select_context() if it helps.

setvik’s picture

setvik commented
StatusFileSize
new ctools-context-exists-access-plugin-4923364-3.patch614 bytes

Take #2.

Rolling a new patch that adds a $skip_name_check parameter to the ctools_context_required object, tests for it in ::select() & only executes the fallback code if the parameter is present.

setvik’s picture

setvik commented
Status: Needs work » Needs review
setvik’s picture

setvik commented
StatusFileSize
new ctools-context-exists-access-plugin-1263896-8.patch2.01 KB

Take #3,

Here's the correct patch

setvik’s picture

setvik commented
StatusFileSize
new ctools-context-exists-access-plugin-1263896-11.patch2.01 KB

Take #4,

Here's the correct patch with the correct file name.

setvik’s picture

setvik commented
Issue summary: View changes

Updating summary to point at latest patch

setvik’s picture

setvik commented
Issue summary: View changes

patch location update

capellic’s picture

capellic
he/him/his
Location Austin, Texas
commented

This patched work for me, thanks!

Kitbash’s picture

Kitbash commented

This patch has saved my bacon -- many thanks!

setvik’s picture

setvik commented
Status: Needs review » Reviewed & tested by the community

Setting to RTBC

capellic’s picture

capellic
he/him/his
Location Austin, Texas
commented

Has this patch been applied to the DEV version? I need to update this module to get another update that did (http://drupal.org/node/1167938)-- I guess I'll apply that patch until at which time this is also committed to the DEV version.

THANK YOU!

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Excellent answer. Committed! THanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

latest patch update