Closed (fixed)
Project:
Display Suite
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Aug 2011 at 20:42 UTC
Updated:
21 Sep 2011 at 13:01 UTC
Jump to comment: Most recent file
Comments
Comment #1
mlncn commentedMay be related to #1155148: Notice: Undefined index: elements in ds_entity_variables()
Comment #2
mlncn commentedPossible that saving some Views settings related to Display Suite made it the notice go away: http://pad.agariclabs.org:9001/p/8x7XeVMiQU
Comment #3
swentel commentedHmm I don't think #1 is related with this. I've got a patch which more or less checks for the same thing as in ds.module itself (the $variables['elements') - although I don't think this would remove the notices) Will do some more tests this weekend.
Comment #4
swentel commentedComment #5
mlncn commentedDisabling the Views Display option (ds_extras_vd) in Display Suite Extras gets rid of the notice.
Note: We did not have any Views Displays defined, perhaps defining one also gets rid of the notice!
Comment #6
mlncn commentedAlso swentel++ for being the most responsive module maintainer pretty much ever.
Comment #7
swentel commentedDamn, I was able to get the notice once and then started coding. Reverted than all my changes and couldn't reproduce it anymore. When I step through the code of Drupal core, it seems like there is some sort of racing condition going on re: caching of bundle settings and entity info. More tests later this week. Note, path in #3 doens't fix anything here, it's really something else.
Comment #8
swentel commentedOk, I can reproduce it. It's a fun racing condition somewhere in core, so it's most likely a bug in core, however, I'll try to fix this in DS as well. To reproduce do this:
- disable views displays
- clear cache via the performance settings page
- enable views displays
- go to say the frontpage view that comes with views -> you'll see the notice
- save the settings screen again of ds extras just once (without any changes) - or clear cache view performance settings page, doesn't matter
- go again to frontpage view -> notice is gone
Let's see if can fix this now :)
Comment #9
swentel commentedAaaaand fixed :) patch attached as well, which cleans up something more as well when managing the layouts. The variable_set('menu_rebuild_needed') is the trick to get rid of the notices though.