Incompatibility with Google Fonts [#1262000]

When a Google font is enabled — in my case, with Google Fonts module — CSS files don't load in ACE editor.

Console messages when, for example, Kranky font is activated on example.com:
On load:
XMLHttpRequest cannot load http://fonts.googleapis.com/css?family=Kranky. Origin http://example.com is not allowed by Access-Control-Allow-Origin.

When a CSS file is selected:
TypeError: 'null' is not an object (evaluating 'this.editor.getSession')

Comment	File	Size	Author
#10	1262000-external-google-fonts-10.patch	457 bytes	fizk

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

guybedford CreditAttribution: guybedford commented 29 August 2011 at 10:31

I included the font with the following tag -

<link href='http://fonts.googleapis.com/css?family=Kranky' rel='stylesheet' type='text/css'>

And Live CSS still worked fine for me.

Are you using a different form of the include?

Comment #2

Pomliane CreditAttribution: Pomliane commented 29 August 2011 at 15:01

Thank you for this answer.

Google Fonts module adds this exact line:
<link type="text/css" rel="stylesheet" href="http://fonts.googleapis.com/css?family=Kranky" />

The same issue happens with other fonts activated via Google Fonts module, but everything seems fine when the font is manually included.

So, maybe not the right issue queue?

Comment #3

guybedford CreditAttribution: guybedford commented 12 September 2011 at 10:44

Actually live css will be loading all the css files in the page using ajax requests to read in their content. It then tries to load the font css file, which causes the origin policy issue, and returns an error. This isn't caught properly which causes things to stop working. I believe it worked fine when I tried because I didn't have the origin policy issue running it off a live site.

I'll look into having a better fail on those ajax requests so that the file effectively isn't editable.

Thanks for reporting this issue - will hopefully have something on it soon.

Comment #4

brankolo CreditAttribution: brankolo commented 1 December 2011 at 11:59

The same problem for me.
Waiting for solution, thanks in advance

Comment #5

guybedford CreditAttribution: guybedford commented 11 December 2011 at 15:48

Status:

Active

» Needs review

I believe I may have fixed this issue with the latest (2.0) version of the module.

Let me know if that works for you.

Comment #6

Pomliane CreditAttribution: Pomliane commented 12 December 2011 at 17:55

Version:	6.x-1.7	» 6.x-2.0
Status:	Needs review	» Needs work

Thank you guybedford for the follow up!

It seems, 6.x-2.0 does not solve the issue when http://drupal.org/project/fontyourface is in use.

Comment #7

Anonymous (not verified) CreditAttribution: Anonymous commented 21 January 2012 at 11:38

this does not solve the fontyourface issue , but I have to say that using cufon instead of fontyourface is a much better way to display fonts on a site. Fonts are a lot cleaner across browser types http://drupal.org/project/cufon