When entering a language domain at admin/config/regional/language/edit/en it should check for the protocol, but that check doesn't happen right, since there's another patch that will remove this so people can use the language domain on http and https at the same time, this is just for reference

related: #1250800: Language domain should work regardless of ports or protocols

CommentFileSizeAuthor
#13 i1261440.patch1.33 KBattiks
#1 i1261440.patch1.54 KBattiks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Active » Postponed
FileSize
i1261440.patch1.54 KB

Attached a patch that changes the description, the patch depends on #1250800: Language domain should work regardless of ports or protocols, so that one has to go in first.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

This sentence does not compute for me: "URL to use for this language, do not any protocol, nor any port.".

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Postponed » Needs review

Gabor, something like this:

Domain name to use for this language, do not use any protocol (like http://) or a port (like: 88).

1 days to next Drupal core point release.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Well, we previously suggested they MUST provide a protocol, right? So what about just saying that the language detection is independent on protocol or port, and let them provide it for backwards compatibility / if they want it anyway. The code change should be backwards compatible anyway. BTW why not do this in the same issue as #1250800: Language domain should work regardless of ports or protocols? I don't see them being unrelated.

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Needs review » Needs work

Domain name to use for this language, you may optionally specify a protocol or a port, but the language will be detected based on only the domain name.

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Needs work » Needs review
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Title: Language domain doesn't check for protocol » Fix language domain configuration description vs. reality
Issue tags: +Usability, +D8MI

Tagging, fixing title.

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs review » Needs work

A first rewrite:

The URL to use for this language if URL domains are used for <em>Detection and selection</em>. Leave blank for the default language. <strong>Changing this value may break existing URLs.</strong> Example: Specifying "de.example.com" as language domain for German will result in URLs like "http://de.example.com/contact.

- Removed the 'don'ts': No need to talk about the things that happen automatically anyway.
- Shorter, single example
- Maybe 'Detection and selection' should be a link to that settings page? Not sure.

attiks’s picture

attiks CreditAttribution: attiks commented

@yoroy, what they have to enter isn't technically a URL, they have to enter a domain name:

The domain name to use for this language if URL domains are used for ...
yoroy’s picture

yoroy CreditAttribution: yoroy commented

Well, that part I did not change ;-p
In that case, domain is indeed better.

attiks’s picture

attiks CreditAttribution: attiks commented

so we have

The domain name to use for this language if URL domains are used for <em>Detection and selection</em>. Leave blank for the default language. <strong>Changing this value may break existing URLs.</strong> Example: Specifying "de.example.com" as language domain for German will result in URLs like "http://de.example.com/contact.
yoroy’s picture

yoroy CreditAttribution: yoroy commented

Still pretty long, but yes.

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Needs work » Needs review
FileSize
i1261440.patch1.33 KB

updated patch

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Looks good to me. Still think this should be rolled into #1250800: Language domain should work regardless of ports or protocols, or if not, marked postponed on that. That issue makes it work as described here, so I think easier would be to get the two in at once.

attiks’s picture

attiks CreditAttribution: attiks commented
Status: Needs review » Closed (duplicate)

Done