The menu callback "node/%node/moderation/%/change-state/%" is unprotected from a CSRF vulnerability where admins could be easily tricked into changing states on nodes. We need to use drupal_get_token() and drupal_valid_token() when creating links and in the callback itself.

This has not been reported to the security team as we do not yet have a final 1.0 release so this is cleared to be fixed publicly.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Status: Active » Needs review
FileSize
1.86 KB
Dave Reid’s picture

Dave Reid’s picture

Revised patch that ensure the token will always be set even after the array_merge() in workbench_moderation_get_moderation_links().

Dave Reid’s picture

That was fun overcoming the broken-ness of DrupalWebTestCase::drupalGetToken().

Dave Reid’s picture

Left one little debug() in. :/

Dave Reid’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.