The menu callback "node/%node/moderation/%/change-state/%" is unprotected from a CSRF vulnerability where admins could be easily tricked into changing states on nodes. We need to use drupal_get_token() and drupal_valid_token() when creating links and in the callback itself.
This has not been reported to the security team as we do not yet have a final 1.0 release so this is cleared to be fixed publicly.
Comments
Comment #1
dave reidComment #2
dave reidComment #3
dave reidRevised patch that ensure the token will always be set even after the array_merge() in workbench_moderation_get_moderation_links().
Comment #4
dave reidThat was fun overcoming the broken-ness of DrupalWebTestCase::drupalGetToken().
Comment #5
dave reidLeft one little debug() in. :/
Comment #6
dave reidCommitted #5 with some doc cleanups to Git!
http://drupalcode.org/project/workbench_moderation.git/commit/2afef61