Again, title explains everything.

As part of this, we should properly document the new hooks in userpoints.api.php

CommentFileSizeAuthor
#2 replace_settings_hook.patch2.46 KBberdir

Comments

BenK’s picture

BenK commented

Subscribing

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new replace_settings_hook.patch2.46 KB

The attached patch replaces $op settings with an own hook and also adds documentation for it.

The before/after hooks will probably be reworked during #1258042: Revamp userpoints_userpointsapi() using an OOP approach similar to SelectQuery.

Note that this will obviously break compatibiliy with all modules which provide settings, but there will be more and bigger API changes anyway so this might actually be a good thing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.