Seems the AWS SDK is picky about variable types and the default (int) 1 wasn't working. The attached patch uses (bool) TRUE instead.

This patch also clears caches for any changes on the settings form, which I hope will lead to fewer "I changed the setting but nothing happened" bugs. If you feel clearing all caches is too heavy handed, perhaps some additional instructions on the page telling folks which settings are cached and which are not. (I believe they all are?)

CommentFileSizeAuthor
#1 1256698-boolean-settings.patch1.73 KBboombatower
awssdk_flush_caches.patch1.42 KBmikeker

Comments

boombatower’s picture

boombatower commented
Title: Certificate Authority checkbox was using 1 instead of TRUE » Add #return_value => TRUE to boolean settings in UI
Version: 7.x-4.0 » 7.x-4.x-dev
StatusFileSize
new 1256698-boolean-settings.patch1.73 KB

Since UI was added after primary module it was overlooked that the cache needed clearing, good catch. :)

Also there seems to be one other variable that requires a boolean so I added #return_value => TRUE to that one as well.

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.