dereine is clever and his attached patch allows the node widget to work properly with references or other potential cases when $values->nid might not exist in the handler's render.

dereine++

CommentFileSizeAuthor
#2 vud-6.x-2.x-1253390-1.patch2.85 KBseandunaway
vud-6.x-2.x-views-fix-nid.patch1.22 KBseandunaway

Comments

seandunaway’s picture

seandunaway commented
Priority: Normal » Major
seandunaway’s picture

seandunaway commented
Title: Views Field Node Widget breaks when using nodereferences » Views Field Node Widget breaks when using Views 3
Priority: Major » Critical
StatusFileSize
new vud-6.x-2.x-1253390-1.patch2.85 KB

Re-rolled to get comments working. Apparently it's not only with node references but with any view in Views 3.

Attached.

seandunaway’s picture

seandunaway commented
Version: 6.x-2.x-dev » 6.x-3.x-dev

Applies cleanly against 6.x-3.x-dev also.

marvil07’s picture

marvil07 commented
Title: Views Field Node Widget breaks when using Views 3 » Views fields on submodules need to explicitely add PKs for views 3 to work correctly
Component: vud_node » Code

I think you are right. It seems like views behaviour have changed from 2 to 3. Now it do not add the primary key of the base table by default. So yes, we would need to change it to be explicit about the primary key we are using on our views field.

I'm now taking a look at the patch.

Thanks for reporting it and providing code :-).

marvil07’s picture

marvil07 commented
Title: Views fields on submodules need to explicitely add PKs for views 3 to work correctly » Make vud submodules views fields implementations compatible with views 3
Priority: Critical » Major
Status: Needs review » Fixed

I have just pushed this patch to 6.x-3.x and 6.x-2.x.

What's new on the patch: same change for vud_node_handler_field_widget handler and minor detals on comments.

Thanks all,

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.