Log blocked form submissions [#1249580]

Sometimes it is useful to log blocked attemtps to use forms. Can this be seen in server logs? As far as I know, it cannot, but if it can, how? If not, can it be logged on the Drupal installation. maybe using Trigger?

The reason it is sometimes useful is illustrated here http://drupal.org/node/1248138#comment-4865186.

Comment	File	Size	Author
#7	log_blocked_submissions-d7-1249580-7.patch	2.47 KB	geerlingguy
#7
#4	log_blocked_submissions_d7-1249580.patch	2.77 KB	Barrett
#4
#2	log_blocked_submissions_d6-1249580.patch	4.01 KB	Barrett
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

geerlingguy CreditAttribution: geerlingguy commented 16 August 2011 at 17:19

Status:

Active

» Postponed

I could probably set an option to log failed attempts (at least, the IP address of the referrer, and the form or path on which the failure happened. Leaving this as postponed until I get a little time to work on it more.

I'd definitely leave this off by default, as writing to the db is expensive (well, more expensive than not writing ;-), and as-is, Honeypot is practically instantaneous in all regards.

Comment #2

Barrett CreditAttribution: Barrett commented 18 August 2011 at 15:47

File	Size
log_blocked_submissions_d6-1249580.patch	4.01 KB

I've put together a 6.x patch for this (attached). When I have a minute, I'll see about porting it to the d7 version.

Comment #3

geerlingguy CreditAttribution: geerlingguy commented 18 August 2011 at 16:00

Status:

Postponed

» Needs review

Patch looks good after a quick readthrough. I'll test and commit as soon as I have time. It would be best if we can keep code formatting/cleanup out of these patches, and tackle that in a separate issue (makes reviewing that much quicker ;-).

If someone else can also review the patch (apply it, test it, see if it works), that would be helpful.

Comment #4

Barrett CreditAttribution: Barrett commented 18 August 2011 at 17:52

File	Size
log_blocked_submissions_d7-1249580.patch	2.77 KB

That'll teach me to assume code format problems are mine, I guess ;^)

Here's a patch against 7x. It does not include the formatting points.

Comment #5

John_B CreditAttribution: John_B commented 20 August 2011 at 11:27

I have applied the 7 patch. No error message. Too soon to have seen any logged rejections. I was unable to trigger one by sending messages in quick succession.

PS if anyone happens to know... can a patch be applied with drush? I had to do it the hard way. 'drush make patch' should to but the make extension is D6 only.

Comment #6

Barrett CreditAttribution: Barrett commented 21 August 2011 at 00:15

John_B, it doesn't appear patching can be done with drush.

For testing, I did a couple things. For the honeypot field, I commented out the css line so that the honeypot field appeared and I tested with the css included and used the TamperData add-on for Firefox to force data into the field.

For the time testing, the only solution I found was to set the limit ridiculously high (45 seconds) so that I could blow the time easily.

Comment #7

geerlingguy CreditAttribution: geerlingguy commented 6 November 2011 at 02:43

File	Size
log_blocked_submissions-d7-1249580-7.patch	2.47 KB

I'm attaching the patch I applied to 7.x - I mostly kept things as they were in #4, but changed the variable to, simply, 'honeypot_log', and didn't save the user's IP address in the log message (since that's stored in the watchdog record already).