Some elements of the user interface are not translatable because of the lack of proper use of the t() and Drupal.t() functions. I’ll post a patch here.

CommentFileSizeAuthor
#3 media_translate-1248730-3.patch3.19 KBidflood
#1 media_translate-1248730-1.patch3.19 KBdboulet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dboulet’s picture

dboulet CreditAttribution: dboulet commented
FileSize
media_translate-1248730-1.patch3.19 KB

Here is everything that I could find so far, I’ll post another patch if I discover more.

dboulet’s picture

dboulet CreditAttribution: dboulet commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

Switched to the 2.x version and same issues remain. Patch still applies.

idflood’s picture

idflood CreditAttribution: idflood commented
FileSize
media_translate-1248730-3.patch3.19 KB

The patch looks good but there was a little mistake of concatenation ( using the php's "." instead of "+" in javascript). Here is a reroll of last patch against 2.x (with the +)

I've tested it and it behave as expected, and the concatenation problem was the only one I spotted after a full review of the code.

dboulet’s picture

dboulet CreditAttribution: dboulet commented
Status: Fixed » Needs review

Thanks for catching that idflood, I think that I worked too many hours that day. :)

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

Committed #3 to both 7.x-2.x and 7.x-1.x.
http://drupalcode.org/project/media.git/commit/7e666bb
http://drupalcode.org/project/media.git/commit/c266b5a

dboulet’s picture

dboulet CreditAttribution: dboulet commented
Status: Needs review » Fixed

Thanks Dave.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.