As a part of my Google Summer of Code project Development Activity logging, Activity Streams and Development Statistics I wrote code to integrate Project Issues with the Activity project. I've also did the same for Project (including Project Release) and the Versioncontrol API. Next to that, I rewrote and bugfixed some parts of Activity, did some extensive work on the Versioncontrol API and its Git backend and wrote the Activity Charts module.

GSoC is coming to an end, and therefor I opened this issue to get my freshly developed code into the Project Issues repository. Attached to this issue is one big patch, namely:

  • project_issues-activity.patch which contains the actual integration with the Activity module.

Why? We want this on drupal.org, or atleast ... there has been a certain interest. Take a look at #1227158: Define what should be displayed on the user's Activity tab and #1227032: Output from Activity stream needs design to see what I mean.

Wanna see it in action? You sure can, have a look at my drupal.org sandbox that's running an older version of the code I posted here: http://dev_activity-drupal.redesign.devdrupal.org/node/3281/activity (drupal/drupal). It needs some theming, but it's surely something cool and handy to have.

Does it work? I did my best to provide tests for all written functionality and in the process I got completely frustrated with EvilSimpleTests.

So that's that, discuss!

CommentFileSizeAuthor
#7 project_issues-activity-2.patch51.24 KBcvangysel
#1 1245356-1.duplicate-activity-entries.png210.1 KBdww
project_issues-activity.patch51.24 KBcvangysel

Comments

dww’s picture

dww
we/he/they
commented
StatusFileSize
new 1245356-1.duplicate-activity-entries.png210.1 KB

Thanks for sharing!

I haven't started looking at the patch.

However, I quickly visited your dev site at the page you listed:

http://dev_activity-drupal.redesign.devdrupal.org/node/3281/activity

I'm seeing a *TON* of duplicate activity stream entries (see attached screenie).

Do I misunderstand what I'm looking at, is the dev site fubar, or is this code broken? ;)

I'll try to find time in the next few days to look at the patch and provide a detailed review...

Thanks again!
-Derek

cvangysel’s picture

cvangysel commented

Last time I tested some new stuff on the dev site I apparently played a little too much with the Views configuration ... I'm currently regenerating everything and it'll be just fine then. Check your personal activity feed (on the dev-site) again in a couple of hours, and it should be better.

sirkitree’s picture

sirkitree commented

Think this is looking a lot better now:

Only local images are allowed.

dww’s picture

dww
we/he/they
commented

Indeed, the per-user profile activity tab is looking sane. The per-project stream appears to be down on the dev site at this point, not sure what's up with that...

It'd be really nice if these links when you comment on an issue actually linked you to the comment you made, not just the issue node itself (or perhaps the verb should also be a link (although it's already pretty overwhelmingly links)).

Anyway, this all seems very slick from the outside. I'll have to start digging more closely to flesh out any problems before committing. Is there a meta issue anywhere about a deployment plan for all this?

Cheers,
-Derek

cvangysel’s picture

cvangysel commented

The project feed is down because I updated to my latest code and didn't have the time yet to set it up. Not yet all data on the dev site is 'correct', I'm regenerating some stuff again now.

About linking to the comment instead of the issue, that's already possible in the way of "dww placed comment #1 on [issue-link]" (where #1 is a link to the comment) etc.

The meta issue(s) are here:

dww’s picture

dww
we/he/they
commented

I replied at #1227158-7: Define what should be displayed on the user's Activity tab which seems like the more appropriate place to discuss the issue comment linking questions (right?).

Thanks,
-Derek

cvangysel’s picture

cvangysel commented
StatusFileSize
new project_issues-activity-2.patch51.24 KB

New patch to follow changes in Project API through #1171828: Let other modules know when a new maintainer is added.