Workbench: My Content Tab: Sort by Section Fails

I cannot duplicate this using the latest code will try with a more complex section setup.

Changing the project for this issue. The "section" column comes from Workbench Access.

I'm not seeing that, but I am getting duplicate results when sorting and using the 'menu' scheme.

The duplicates only appear after sorting by section. These bugs are probably related.

I can replicate something similar to the original issue as well. We may just need to remove the sorting feature.

For taxonomy, line 33 is not returning any value, which may be breaking the query.

      $table = $this->query->ensure_table($sort['table']);

I've always struggled with that method, which seems very inconsistent in Views.

The table _is_ correctly added when using menus, but I believe the JOINs are causing duplicate records.

We should probably just remove the sort-ability considering that multiple sections can be in the field.

Tested #8 manually and ran tests. Committed to Git.
http://drupalcode.org/project/workbench_access.git/commit/d0c2efb

Moving back to needs work for investigation.

We are not supporting a sort by Section column at this time. The commit from #1243186-9: Workbench: My Content Tab: Sort by Section Fails removes this capability. We're all set here.

This is just for documentation. I have a view that needs to be sorted by section. In my case only one section can be assigned to a node, so it worked for me:

function mymodule_views_query_alter(&$view, &$query) {

	if (is_numeric(strripos($view->tag, 'WB_CLONE')) && ($view->base_table == 'node' || $view->base_table == 'node_revision')) {

		$join = new views_join();
		$join->type = 'LEFT';
		$join->left_table = 'node';
		$join->left_field = 'nid';
		$join->table = 'workbench_access_node';
		$join->field = 'nid';

		// Do the actual join
		$query->table_queue['workbench_access_node'] = array (
		  'alias' => 'workbench_access_node',
		  'table' => 'workbench_access_node',
		  'relationship' => 'node',
		  'join' => $join,
		);

		$join = new views_join();
		$join->type = 'LEFT';
		$join->left_table = 'workbench_access_node';
		$join->left_field = 'access_id';
		$join->table = 'taxonomy_term_data';
		$join->field = 'tid';

		// Do the actual join
		$query->table_queue['taxonomy_term_data'] = array (
		  'alias' => 'taxonomy_term_data',
		  'table' => 'taxonomy_term_data',
		  'relationship' => 'workbench_access_node',
		  'join' => $join,
		);

		$query->fields['my_section'] = array(
		      'field' => 'name',
		      'table' => 'taxonomy_term_data',
		      'alias' => 'my_section'
		);

		$section_sort = array(
		      'field' => 'my_section',
		      'direction' => 'ASC'
		);

		array_unshift($query->orderby, $section_sort);

	}

}

Thanks to this post for the instructions on how to modify a views query. The database api methods don't work here.