Closed (fixed)
Project:
Debut
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Aug 2011 at 09:39 UTC
Updated:
4 Jan 2014 at 01:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ao2 commentedPatch attached containing two commits, the first one fixes files permissions so that they are not executables on Unix systems. The second change fixes this very issue.
You can apply it with
git amto keep the commits distinct as they should be.Thanks,
Antonio
Comment #2
nedjoThis was fixed.
Comment #3
ao2 commentedThank nedjo, I see the fix in f49fb7d, even if I don't figure as the author in the git history. Please next time consider using
git am, orgit commit --author ...to give attribution. In this case the patch contained two commits, but they could have been splitted with a text editor, or you could have discarded one atgit amtime or by using a local branch andgit rebase -i ...before merging it.These are just reminders, I always appreciate your work.
Regards,
Antonio
Comment #4
nedjoHi Antonio,
Thanks for posting the patch and for the reminder. I've been a slow learner with git, but I'll make sure to properly assign credit properly as well as the old style commit message hack. I'm happy to assign you commit access to any debut features if you're working with them--just let me know.
Thanks! Nedjo