I'm not 100% sure if this is actually needed, but it rounds out the API nicely.
Usage of entity_load_multiple_by_name() borrowed from search_api.

CommentFileSizeAuthor
#5 field_collection-1239416-5.patch1.43 KBtim.plunkett
#3 field_collection-1239416-3.patch1.4 KBtim.plunkett
#1 field_collection-1239416-1.patch882 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new field_collection-1239416-1.patch882 bytes
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

+1 for adding such a helper, field-collection items are not identified by name though. Thus we should use entity_load().

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new field_collection-1239416-3.patch1.4 KB

Now with basic doxygen.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work 
+ *   An aray of field_collection_item objects.

Typo in array. Also let's specify the return type in case of the single load so IDEs can pick that up. Then, I'd not call them field_collection_item objects, but "field-collections items" or "field-collection item entities".

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new field_collection-1239416-5.patch1.43 KB

Sounds good.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jmuzz’s picture

jmuzz commented
Issue summary: View changes
Status: Needs work » Closed (fixed)

I don't understand, the last few posts point to this being fixed, but somehow the issue is "Needs Work."

I'm setting it to fixed.