This issue is a cross-referenced with #1176454: Moving fieldsets into another region leaves children behind. Please read the comment in #10 first before taking up this issue.
In short:
Fields that belong to fieldgroups are not warned they need to move along with their wrapper. A small refactoring in field_group and some additional check in Display Suite can take up the recursive check so that when field groups are moved, everything under it is moved as well.
New code in display suite (patch is coming up with this issue number):
regionChange: function (region) {
...
// If a row is handled by field_group module, loop through the children.
if ($(this.row).hasClass('field-group')) {
Drupal.fieldUIDisplayOverview.group.prototype.regionChangeFields(region, this, refreshRows);
}
return refreshRows;
}
Please checkout field_group from git when trying out.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1238048_2.patch | 1.08 KB | Stalski |
| #3 | 1238048_1.patch | 1.01 KB | Stalski |
| #1 | 1238048.patch | 1.02 KB | Stalski |
Comments
Comment #1
Stalski commentedThe patch for DS.
Comment #2
Stalski commentedSome additional remarks:
- We need to check if this works recursively for fieldgroups in fieldgroups
- We need to think about the check on the html class "field-group". This might not be the only thing we can look at when deciding to go down the tree.
Comment #3
Stalski commentedpatch without white-spaces.
Comment #4
Stalski commentedThis patch includes an extra check on the function call in javascript.
Comment #5
swentel commentedcommitted and pushed, cool!