For some reason tags aren't being parsed in comments e.g. [view:example=20=arg]. Currently logged in as super admin uid 1. Input type claims to allow it. Works as advertized in a normal post.

CommentFileSizeAuthor
#3 insert_view-filter_process.diff1.31 KBPogo

Comments

Pogo’s picture

Pogo commented

The problem is that insert_view is a pseudo-filter, it doesn't implement hook_filter. Instead of it, it uses nodeapi to replace [view:...] with the view itself. This way it only works for nodes. Comment, term description, even block is not a node.

Pogo’s picture

Pogo commented

Actually it does implement hook_filter but it doesn't do the processing (replacement of [view:...] with the view) in it.

Pogo’s picture

Pogo commented
Status: Active » Needs review
StatusFileSize
new insert_view-filter_process.diff1.31 KB

I resolved it but it's more a hack than a correct solution. Module owner, please review.

mlsamuelson’s picture

mlsamuelson commented
Status: Needs review » Fixed

Pogo,

Somehow I managed to overlook this issue. My apologies.

I recently committed an update that was very nearly identical to your solution, making Insert View a true filter module.

Not really hacky at all.

Thanks for the patch.

HEAD and the D5 branch reflect the update.

mlsamuelson

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.