Trying to create a field of type list<text>, triggers a Unknown field type text. Database search module might be out of sync with Search API. exception in the database engine.

This is because ->fieldsUpdated() doesn't properly extract the inner type when taking the decision of what to do.

CommentFileSizeAuthor
#5 1232478-inner-types-db-engine.patch3.57 KBdamien tournoud
#4 1232478--inner-type-db-backend-4.patch2.44 KBdrunken monkey
#3 1232478-inner-types-db-engine.patch2.44 KBdamien tournoud
#1 1232478-inner-types-db-engine.patch2.35 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 1232478-inner-types-db-engine.patch2.35 KB

This fixes it, and probably a couple of related bugs.

I see no obvious way of extending the automated tests to cover this, so I'll let it as an exercise for the reader.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Needs work 
+++ b/contrib/search_api_db/service.inc
@@ -246,17 +248,17 @@ class SearchApiDbService extends SearchApiAbstractService {
         }
       }
-      elseif (!$reindex && $new_type == 'text' && $field['boost'] != $new_fields[$name]['boost']) {
+      elseif (!$reindex && $new_inner_type == 'text' && $field['boost'] != $new_fields[$name]['boost']) {
         $multiplier = $new_fields[$name]['boost'] / $field['boost'];

Unless I'm mistaken, $new_inner_type won't be set here, as you set that inside of the above if block. You could just use seach_api_is_text_type($new_type) instead – or extract the types outside of the blocks,of course.

Otherwise, the patch looks good, thanks a lot for spotting this!

damien tournoud’s picture

damien tournoud commented
Status: Needs work » Needs review
StatusFileSize
new 1232478-inner-types-db-engine.patch2.44 KB

Good catch. Here is a fixed version.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: DB engine doesn't support list<text> » Fix update of field settings for DB backend
StatusFileSize
new 1232478--inner-type-db-backend-4.patch2.44 KB

Patch looks good, but I think there are still cases where this wouldn't work – mostly, when the list level of a field type changes (which might happen e.g. with data alterations, or when switching a field from single-valued to multi-valued). Please see if the attached patch works for you, too.

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 1232478-inner-types-db-engine.patch3.57 KB

Ok, but this encovered another issue: _search_api_admin_get_fields() never updates the nesting level of a known field...

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Fix update of field settings for DB backend » Fix update of field type settings for DB backend and index
Status: Needs review » Fixed

Ok, but this encovered another issue: _search_api_admin_get_fields() never updates the nesting level of a known field...

Wow, awesome that you spotted and fixed that!
Patch looks good now and also seems to work – committed, thanks again!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.