Fix update of field type settings for DB backend and index [#1232478]

Trying to create a field of type list<text>, triggers a Unknown field type text. Database search module might be out of sync with Search API. exception in the database engine.

This is because ->fieldsUpdated() doesn't properly extract the inner type when taking the decision of what to do.

Comment	File	Size	Author
#5	1232478-inner-types-db-engine.patch	3.57 KB	Damien Tournoud
#5
#4	1232478--inner-type-db-backend-4.patch	2.44 KB	drunken monkey
#4
#3	1232478-inner-types-db-engine.patch	2.44 KB	Damien Tournoud
#3
#1	1232478-inner-types-db-engine.patch	2.35 KB	Damien Tournoud
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Damien Tournoud CreditAttribution: Damien Tournoud commented 28 July 2011 at 15:03

Status:

Active

» Needs review

File	Size
1232478-inner-types-db-engine.patch	2.35 KB

This fixes it, and probably a couple of related bugs.

I see no obvious way of extending the automated tests to cover this, so I'll let it as an exercise for the reader.

Comment #2

drunken monkey

he/him

German

Vienna, Austria

CreditAttribution: drunken monkey commented 28 July 2011 at 19:09

Status:

Needs review

» Needs work

+++ b/contrib/search_api_db/service.inc
@@ -246,17 +248,17 @@ class SearchApiDbService extends SearchApiAbstractService {
         }
       }
-      elseif (!$reindex && $new_type == 'text' && $field['boost'] != $new_fields[$name]['boost']) {
+      elseif (!$reindex && $new_inner_type == 'text' && $field['boost'] != $new_fields[$name]['boost']) {
         $multiplier = $new_fields[$name]['boost'] / $field['boost'];

Unless I'm mistaken, $new_inner_type won't be set here, as you set that inside of the above if block. You could just use seach_api_is_text_type($new_type) instead – or extract the types outside of the blocks,of course.

Otherwise, the patch looks good, thanks a lot for spotting this!

Comment #3

Damien Tournoud CreditAttribution: Damien Tournoud commented 4 August 2011 at 10:21

Status:

Needs work

» Needs review

File	Size
1232478-inner-types-db-engine.patch	2.44 KB

Good catch. Here is a fixed version.

Comment #4

drunken monkey

he/him

German

Vienna, Austria

CreditAttribution: drunken monkey commented 4 August 2011 at 10:34

Title:

DB engine doesn't support list<text>

» Fix update of field settings for DB backend

File	Size
1232478--inner-type-db-backend-4.patch	2.44 KB

Patch looks good, but I think there are still cases where this wouldn't work – mostly, when the list level of a field type changes (which might happen e.g. with data alterations, or when switching a field from single-valued to multi-valued). Please see if the attached patch works for you, too.