Hello, Gents.

I've add an argument ('news/!myparameter') to the 'path' parameter for my news panel, where the argument is a YYYYMM date argument. But i didn't set any settings in the 'arguments' section and i got this error on the page:

Notice: Undefined index: name in function page_manager_page_execute() (string 293 in file XXX/sites/all/modules/ctools/page_manager/plugins/tasks/page.inc).

The piece of code, which cause this error is:
/sites/all/modules/ctools/page_manager/plugins/tasks/page.inc

291        if (isset($args[$count])) {
292          // Hack: use a special argument config variable to learn if we need
293          $plugin = ctools_get_argument($argument['name']);
294          // to use menu_tail style behavior:
295          if (empty($argument['settings']['use_tail'])) {

I did quick reserch and found out that:
1. The $plugin variable never used in function again
2. The $argument array has no 'name' index yet (of course, till it will be defined in the 'arguments' section of the panel)

My suggestion is - add additional validation for $argument['name'] index or remove whole string 293 (because it is usless).

Comments

merlinofchaos’s picture

Status:Active» Fixed

Yeah, that line doesn't appear to need to be there, and is splitting a comment besides. Not sure what was going on with that line. But removing it seems fine. Fixed in both 6.x and 7.x

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary:View changes

the description of the bug was extended a bit