Currently, in MySQL, the options for servers, indexes, pages and facets are "only" 16 KB large. While this is plenty, it might still be exhausted, especially for indexes with complicated data structures. Therefore I think we should increase the size to "medium", giving it 16 MB of space (which I dare anyone to fill up). (Under PostgreSQL, the size is unlimited in any case.)
To be on the safe side, I'd also increase it for servers and facets – only pages have a fixed set of options and can therefore stay at the lower size, in my opinion.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1228726--options-fields-size-4.patch | 1.5 KB | mh86 |
| #3 | 1228726--options-fields-size-3.patch | 1.5 KB | drunken monkey |
| #1 | 1228726--options-fields-size.patch | 2.49 KB | drunken monkey |
Comments
Comment #1
drunken monkeyComment #2
mh86 commentedWe don't need to care about the search_api_facets any more, but the rest looks good to me (didn't test the update functions yet)
Comment #3
drunken monkeyComment #4
mh86 commentedhere the updated patch that fixes clashes in the update function version number
Comment #5
drunken monkeyAh, of course, thanks!
And would you say this is RTBC now?
Comment #6
mh86 commentedyes, RTBC, but didn't want to do that on my own patch ;)
Comment #7
drunken monkeyMakes sense, yes, but as it also works for me, and I don't think we'll get another reviewer …
Committed, thanks!