In sf_import's implementation of hook_cron(), no checking is done to see if there is an active connection with Salesforce API. Among other things, this means that the `sf_import_queue_last_import` and other sf_import timestamps are incorrectly set on each cron run, regardless of whether an actual query to Salesforce for updated items occurred.

Additionally, we might want to consider adding another variable like `sf_import_queue_last_import_attempt` to distinguish attempts from successful imports.

CommentFileSizeAuthor
#1 cron_api_connect-1227794-1.patch928 byteskostajh

Comments

kostajh’s picture

Status: Active » Needs review
Issue tags: +7.x-2.x
StatusFileSize
new928 bytes
EvanDonovan’s picture

Thanks, I think the implementation we'll do of the queue might render this not necessary, or at least have to be handled in a different way, but I will still track this.

kostajh’s picture

Status: Needs review » Patch (to be ported)
EvanDonovan’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev
EvanDonovan’s picture

Status: Patch (to be ported) » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.